From: Andrea Arcangeli <aarcange@redhat.com>
To: linux-mm@kvack.org
Cc: Johannes Weiner <jweiner@redhat.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>,
Richard Davies <richard@arachsys.com>,
Shaohua Li <shli@kernel.org>, Rafael Aquini <aquini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hush Bensen <hush.bensen@gmail.com>
Subject: [PATCH 8/9] mm: zone_reclaim: after a successful zone_reclaim check the min watermark
Date: Fri, 2 Aug 2013 18:06:35 +0200 [thread overview]
Message-ID: <1375459596-30061-9-git-send-email-aarcange@redhat.com> (raw)
In-Reply-To: <1375459596-30061-1-git-send-email-aarcange@redhat.com>
If we're in the fast path and we succeeded zone_reclaim(), it means we
freed enough memory and we can use the min watermark to have some
margin against concurrent allocations from other CPUs or interrupts.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
mm/page_alloc.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b32ecde..879a3fd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1990,8 +1990,26 @@ zonelist_scan:
case ZONE_RECLAIM_FULL:
/* scanned but unreclaimable */
continue;
+ case ZONE_RECLAIM_SUCCESS:
+ /*
+ * If we successfully reclaimed
+ * enough, allow allocations up to the
+ * min watermark (instead of stopping
+ * at "mark"). This provides some more
+ * margin against parallel
+ * allocations. Using the min
+ * watermark doesn't alter when we
+ * wakeup kswapd. It also doesn't
+ * alter the synchronous direct
+ * reclaim behavior of zone_reclaim()
+ * that will still be invoked at the
+ * next pass if we're still below the
+ * low watermark (even if kswapd isn't
+ * woken).
+ */
+ mark = min_wmark_pages(zone);
+ /* Fall through */
default:
- /* did we reclaim enough */
if (zone_watermark_ok(zone, order, mark,
classzone_idx, alloc_flags))
goto try_this_zone;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-02 16:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 16:06 [PATCH 0/9] adding compaction to zone_reclaim_mode v3 Andrea Arcangeli
2013-08-02 16:06 ` [PATCH 1/9] mm: zone_reclaim: remove ZONE_RECLAIM_LOCKED Andrea Arcangeli
2013-08-05 18:30 ` Johannes Weiner
2013-08-07 15:13 ` Mel Gorman
2013-08-02 16:06 ` [PATCH 2/9] mm: zone_reclaim: compaction: scan all memory with /proc/sys/vm/compact_memory Andrea Arcangeli
2013-08-05 18:45 ` Johannes Weiner
2013-08-06 5:50 ` Andrea Arcangeli
2013-08-02 16:06 ` [PATCH 3/9] mm: zone_reclaim: compaction: don't depend on kswapd to invoke reset_isolation_suitable Andrea Arcangeli
2013-08-05 19:32 ` Johannes Weiner
2013-08-02 16:06 ` [PATCH 4/9] mm: zone_reclaim: compaction: reset before initializing the scan cursors Andrea Arcangeli
2013-08-05 19:44 ` Johannes Weiner
2013-08-02 16:06 ` [PATCH 5/9] mm: compaction: don't require high order pages below min wmark Andrea Arcangeli
2013-08-05 18:35 ` Rik van Riel
2013-08-06 13:23 ` Johannes Weiner
2013-08-07 15:42 ` Mel Gorman
2013-08-07 16:14 ` Andrea Arcangeli
2013-08-07 16:47 ` Mel Gorman
2013-08-08 0:59 ` Andrea Arcangeli
2013-08-02 16:06 ` [PATCH 6/9] mm: zone_reclaim: compaction: increase the high order pages in the watermarks Andrea Arcangeli
2013-08-05 18:36 ` Rik van Riel
2013-08-06 16:08 ` Johannes Weiner
2013-08-06 18:52 ` Johannes Weiner
2013-08-07 13:18 ` Andrea Arcangeli
2013-08-07 15:43 ` Mel Gorman
2013-08-02 16:06 ` [PATCH 7/9] mm: zone_reclaim: compaction: export compact_zone_order() Andrea Arcangeli
2013-08-05 18:37 ` Rik van Riel
2013-08-07 15:48 ` Mel Gorman
2013-08-02 16:06 ` Andrea Arcangeli [this message]
2013-08-05 18:38 ` [PATCH 8/9] mm: zone_reclaim: after a successful zone_reclaim check the min watermark Rik van Riel
2013-08-07 15:53 ` Mel Gorman
2013-08-02 16:06 ` [PATCH 9/9] mm: zone_reclaim: compaction: add compaction to zone_reclaim_mode Andrea Arcangeli
2013-08-04 16:55 ` Andrea Arcangeli
2013-08-05 18:38 ` Rik van Riel
2013-08-07 16:18 ` Mel Gorman
2013-08-07 23:48 ` Andrea Arcangeli
2013-08-08 8:22 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375459596-30061-9-git-send-email-aarcange@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=hush.bensen@gmail.com \
--cc=jweiner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=richard@arachsys.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).