linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Manjunath Goudar <manjunath.goudar@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Cc: patches@linaro.org, arnd@linaro.org, dsaxena@linaro.org,
	manjunath.goudar@linaro.org, linaro-kernel@lists.linaro.org,
	IWAMOTO Toshihiro <iwamoto@valinux.co.jp>,
	Hirokazu Takahashi <taka@valinux.co.jp>,
	Dave Hansen <haveblue@us.ibm.com>,
	linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Balbir Singh <bsingharora@gmail.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH] MM: Make Contiguous Memory Allocator depends on MMU
Date: Sun,  4 Aug 2013 10:41:01 +0530	[thread overview]
Message-ID: <1375593061-11350-1-git-send-email-manjunath.goudar@linaro.org> (raw)

s patch adds a Kconfig dependency on an MMU being available before
CMA can be enabled.  Without this patch, CMA can be enabled on an
MMU-less system which can lead to issues. This was discovered during
randconfig testing, in which CMA was enabled w/o MMU being enabled,
leading to the following error:

 CC      mm/migrate.o
mm/migrate.c: In function a??remove_migration_ptea??:
mm/migrate.c:134:3: error: implicit declaration of function a??pmd_trans_hugea??
[-Werror=implicit-function-declaration]
   if (pmd_trans_huge(*pmd))
   ^
mm/migrate.c:137:3: error: implicit declaration of function a??pte_offset_mapa??
[-Werror=implicit-function-declaration]
   ptep = pte_offset_map(pmd, addr);

Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
Acked-by: Arnd Bergmann <arnd@linaro.org>
Cc: Deepak Saxena <dsaxena@linaro.org>
Cc: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
Cc: Hirokazu Takahashi <taka@valinux.co.jp>
Cc: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-mm@kvack.org
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/Kconfig b/mm/Kconfig
index 256bfd0..ad6b98e 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY
 
 config CMA
 	bool "Contiguous Memory Allocator"
-	depends on HAVE_MEMBLOCK
+	depends on MMU && HAVE_MEMBLOCK
 	select MIGRATION
 	select MEMORY_ISOLATION
 	help
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2013-08-04  5:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-04  5:11 Manjunath Goudar [this message]
2013-08-04  7:54 ` [PATCH] MM: Make Contiguous Memory Allocator depends on MMU Wanpeng Li
2013-08-04  7:54 ` Wanpeng Li
2013-08-04  7:54 ` Wanpeng Li
2013-08-04  8:09 ` Michal Hocko
2013-08-04  8:17   ` Manjunath Goudar
     [not found] ` <51fe08c6.87ef440a.10fc.1786SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-04  8:03   ` Manjunath Goudar
2013-08-05  4:40   ` Manjunath Goudar
2013-08-05  7:32     ` Michal Hocko
2013-08-05  8:37       ` Manjunath Goudar
2013-08-05  9:04         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375593061-11350-1-git-send-email-manjunath.goudar@linaro.org \
    --to=manjunath.goudar@linaro.org \
    --cc=arnd@linaro.org \
    --cc=bsingharora@gmail.com \
    --cc=dsaxena@linaro.org \
    --cc=hannes@cmpxchg.org \
    --cc=haveblue@us.ibm.com \
    --cc=iwamoto@valinux.co.jp \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=patches@linaro.org \
    --cc=taka@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).