From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dave Hansen <dave@sr71.net>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 3/7] drivers: base: use device get/put functions
Date: Tue, 20 Aug 2013 12:12:59 -0500 [thread overview]
Message-ID: <1377018783-26756-3-git-send-email-sjenning@linux.vnet.ibm.com> (raw)
In-Reply-To: <1377018783-26756-1-git-send-email-sjenning@linux.vnet.ibm.com>
Use the [get|put]_device functions for ref'ing the memory block device
rather than the kobject functions which should be hidden away by the
device layer.
Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
---
drivers/base/memory.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index e771e2b..a77753c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -616,14 +616,14 @@ static int add_memory_section(int nid, struct mem_section *section,
if (scn_nr >= (*mem_p)->start_section_nr &&
scn_nr <= (*mem_p)->end_section_nr) {
mem = *mem_p;
- kobject_get(&mem->dev.kobj);
+ get_device(&mem->dev);
}
} else
mem = find_memory_block(section);
if (mem) {
mem->section_count++;
- kobject_put(&mem->dev.kobj);
+ put_device(&mem->dev);
} else {
ret = init_memory_block(&mem, section, state);
/* store memory_block pointer for next loop */
@@ -663,7 +663,7 @@ unregister_memory(struct memory_block *memory)
BUG_ON(memory->dev.bus != &memory_subsys);
/* drop the ref. we got in remove_memory_block() */
- kobject_put(&memory->dev.kobj);
+ put_device(&memory->dev);
device_unregister(&memory->dev);
}
@@ -680,7 +680,7 @@ static int remove_memory_block(unsigned long node_id,
if (mem->section_count == 0)
unregister_memory(mem);
else
- kobject_put(&mem->dev.kobj);
+ put_device(&mem->dev);
mutex_unlock(&mem_sysfs_mutex);
return 0;
--
1.8.3.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-20 17:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 17:12 [PATCH 1/7] drivers: base: move mutex lock out of add_memory_section() Seth Jennings
2013-08-20 17:12 ` [PATCH 2/7] drivers: base: remove unneeded variable Seth Jennings
2013-08-20 17:12 ` Seth Jennings [this message]
2013-08-20 17:13 ` [PATCH 4/7] drivers: base: unshare add_memory_section() from hotplug Seth Jennings
2013-08-20 17:13 ` [PATCH 5/7] drivers: base: reduce add_memory_section() for boot-time only Seth Jennings
2013-08-20 17:13 ` [PATCH 6/7] drivers: base: remove improper get/put in add_memory_section() Seth Jennings
2013-08-20 17:13 ` [PATCH 7/7] drivers: base: refactor add_memory_section() to add_memory_block() Seth Jennings
2013-08-22 8:20 ` Yasuaki Ishimatsu
2013-08-22 8:30 ` Yasuaki Ishimatsu
2013-08-22 15:11 ` Seth Jennings
2013-08-20 17:24 ` [PATCH 1/7] drivers: base: move mutex lock out of add_memory_section() Seth Jennings
2013-08-21 18:50 ` Greg Kroah-Hartman
2013-08-22 8:44 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377018783-26756-3-git-send-email-sjenning@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cody@linux.vnet.ibm.com \
--cc=dave@sr71.net \
--cc=gregkh@linuxfoundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).