From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Tony Luck <tony.luck@intel.com>,
gong.chen@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v2 3/3] mm/hwpoison: fix return value of madvise_hwpoison
Date: Tue, 27 Aug 2013 10:39:31 +0800 [thread overview]
Message-ID: <1377571171-9958-3-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1377571171-9958-1-git-send-email-liwanp@linux.vnet.ibm.com>
The return value outside for loop is always zero which means madvise_hwpoison
return success, however, this is not truth for soft_offline_page w/ failure
return value.
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
mm/madvise.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index a20764c..19b71e4 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -359,7 +359,7 @@ static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
page_to_pfn(p), start);
ret = soft_offline_page(p, MF_COUNT_INCREASED);
if (ret)
- break;
+ return ret;
continue;
}
pr_info("Injecting memory failure for page %#lx at %#lx\n",
--
1.8.1.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-27 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 2:39 [PATCH v2 1/3] mm/hwpoison: fix bug triggered by unpoison empty zero page Wanpeng Li
2013-08-27 2:39 ` [PATCH v2 2/3] mm/hwpoison: change permission of corrupt-pfn/unpoison-pfn to 0200 Wanpeng Li
2013-08-27 2:39 ` Wanpeng Li [this message]
2013-08-27 3:28 ` [PATCH v2 3/3] mm/hwpoison: fix return value of madvise_hwpoison Naoya Horiguchi
2013-08-27 3:38 ` Wanpeng Li
2013-08-27 3:38 ` Wanpeng Li
[not found] ` <521c1f3f.813d320a.6ba7.5a17SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-27 3:41 ` Naoya Horiguchi
2013-08-27 7:37 ` Chen Gong
2013-08-27 8:02 ` Wanpeng Li
2013-08-27 8:02 ` Wanpeng Li
2013-08-27 8:05 ` Wanpeng Li
2013-08-27 8:07 ` Chen Gong
2013-08-27 8:05 ` Wanpeng Li
[not found] ` <521c5ddd.c9fc440a.2724.ffff8c70SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-27 21:34 ` Andrew Morton
2013-08-27 3:28 ` [PATCH v2 1/3] mm/hwpoison: fix bug triggered by unpoison empty zero page Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377571171-9958-3-git-send-email-liwanp@linux.vnet.ibm.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).