From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Michal Hocko <mhocko@suse.cz>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [bug] get_maintainer.pl incomplete output
Date: Thu, 17 Oct 2013 12:23:55 -0700 [thread overview]
Message-ID: <1382037835.22110.137.camel@joe-AO722> (raw)
In-Reply-To: <20131017121215.826ab6cced73118f3dba8d4f@linux-foundation.org>
On Thu, 2013-10-17 at 12:12 -0700, Andrew Morton wrote:
> On Wed, 16 Oct 2013 20:51:18 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
>
> > I haven't looked closely at scripts/get_maintainer.pl, but I recently
> > wrote a patch touching mm/vmpressure.c and it doesn't list the file's
> > author, Anton Vorontsov <anton.vorontsov@linaro.org>.
> >
> > Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is
> > missing and git blame attributs >90% of the lines to his authorship.
> >
> > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c
> > Tejun Heo <tj@kernel.org> (commit_signer:6/7=86%)
> > Michal Hocko <mhocko@suse.cz> (commit_signer:5/7=71%)
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:4/7=57%)
> > Li Zefan <lizefan@huawei.com> (commit_signer:3/7=43%)
> > "Kirill A. Shutemov" <kirill@shutemov.name> (commit_signer:1/7=14%)
> > linux-mm@kvack.org (open list:MEMORY MANAGEMENT)
> > linux-kernel@vger.kernel.org (open list)
>
> get_maintainer should, by default, answer the question "who should I
> email about this file". It clearly isn't doing this, and that's a
> pretty big fail.
I disagree.
It's decidedly good at doing precisely that when a
MAINTAINERS entry exists.
When no one is a listed maintainer, the results
can certainly be tweaked to be better.
> I've learned not to trust it, so when I use it I always have to check
> its homework with "git log | grep Author" :(
>
> Joe, pretty please?
It's really a question of "how long ago is too long ago" as
older commits way too often also show old/invalid email
addresses.
I also don't want to wait over 30 seconds or so to find out
who is listed as a git signer/author by default.
Adding the commit listed "Author:" as a signer doesn't seem
too hard though. I'll play with that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-17 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 0:43 [patch] mm, vmpressure: add high level David Rientjes
2013-10-17 3:05 ` Anton Vorontsov
2013-10-17 3:44 ` David Rientjes
2013-10-17 3:51 ` [bug] get_maintainer.pl incomplete output David Rientjes
2013-10-17 4:03 ` Joe Perches
2013-10-17 4:19 ` David Rientjes
2013-10-17 4:36 ` Joe Perches
2013-10-17 19:12 ` Andrew Morton
2013-10-17 19:23 ` Joe Perches [this message]
2013-10-18 4:17 ` Joe Perches
2013-10-18 22:58 ` David Rientjes
2013-10-19 0:25 ` Joe Perches
2013-11-14 21:56 ` [PATCH] get_maintainer: Add commit author information to --rolestats Joe Perches
2013-11-15 2:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382037835.22110.137.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).