From: Joe Perches <joe@perches.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Michal Hocko <mhocko@suse.cz>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [bug] get_maintainer.pl incomplete output
Date: Fri, 18 Oct 2013 17:25:57 -0700 [thread overview]
Message-ID: <1382142357.2041.12.camel@joe-AO722> (raw)
In-Reply-To: <alpine.DEB.2.02.1310181557020.20283@chino.kir.corp.google.com>
On Fri, 2013-10-18 at 15:58 -0700, David Rientjes wrote:
> On Thu, 17 Oct 2013, Joe Perches wrote:
> > Try this:
> > It adds authored/lines_added/lines_deleted to rolestats
> > For instance:
> > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c
> > Tejun Heo <tj@kernel.org> (commit_signer:6/7=86%,authored:3/7=43%,removed_lines:15/21=71%)
> > Michal Hocko <mhocko@suse.cz> (commit_signer:5/7=71%,authored:3/7=43%,added_lines:22/408=5%,removed_lines:6/21=29%)
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:4/7=57%)
> > Li Zefan <lizefan@huawei.com> (commit_signer:3/7=43%)
> > "Kirill A. Shutemov" <kirill@shutemov.name> (commit_signer:1/7=14%)
> > Anton Vorontsov <anton.vorontsov@linaro.org> (authored:1/7=14%,added_lines:374/408=92%)
> > linux-mm@kvack.org (open list:MEMORY MANAGEMENT)
> > linux-kernel@vger.kernel.org (open list)
> >
> > I haven't tested it much.
> This looks good, thanks very much!
Oh sure, it's a trifle.
> I'm not sure how useful the
> removed_lines stat is, but perhaps it can be useful for someone to chime
> in if someone proposes a patch that includes support that had already been
> removed.
The whole concept of lines +/- is kind of dubious.
Quantity really doesn't judge value.
It makes some sense for patches where new files
are added, but new files are a relatively a small
percentage of the overall kernel source tree.
Let it stew for awhile in Andrew's tree and when
-next opens up again, let's see if there are any
other comments about it.
My guess is very few people will notice.
The best mechanism is to have MAINTAINERS entries.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-19 0:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 0:43 [patch] mm, vmpressure: add high level David Rientjes
2013-10-17 3:05 ` Anton Vorontsov
2013-10-17 3:44 ` David Rientjes
2013-10-17 3:51 ` [bug] get_maintainer.pl incomplete output David Rientjes
2013-10-17 4:03 ` Joe Perches
2013-10-17 4:19 ` David Rientjes
2013-10-17 4:36 ` Joe Perches
2013-10-17 19:12 ` Andrew Morton
2013-10-17 19:23 ` Joe Perches
2013-10-18 4:17 ` Joe Perches
2013-10-18 22:58 ` David Rientjes
2013-10-19 0:25 ` Joe Perches [this message]
2013-11-14 21:56 ` [PATCH] get_maintainer: Add commit author information to --rolestats Joe Perches
2013-11-15 2:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382142357.2041.12.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).