* [PATCH] sparc64: fix build regession
@ 2013-11-18 9:44 Kirill A. Shutemov
2013-11-18 23:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kirill A. Shutemov @ 2013-11-18 9:44 UTC (permalink / raw)
To: David S. Miller
Cc: Geert Uytterhoeven, Stephen Rothwell, Andrew Morton, linux-kernel,
linux-mm, Kirill A. Shutemov
Commit ea1e7ed33708 triggers build regression on sparc64.
include/linux/mm.h:1391:2: error: implicit declaration of function 'pgtable_cache_init' [-Werror=implicit-function-declaration]
arch/sparc/include/asm/pgtable_64.h:978:13: error: conflicting types for 'pgtable_cache_init' [-Werror]
It happens due headers include loop:
<linux/mm.h> -> <asm/pgtable.h> -> <asm/pgtable_64.h> ->
<asm/tlbflush.h> -> <asm/tlbflush_64.h> -> <linux/mm.h>
Let's drop <linux/mm.h> include from asm/tlbflush_64.h.
Build tested with allmodconfig.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/sparc/include/asm/tlbflush_64.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sparc/include/asm/tlbflush_64.h b/arch/sparc/include/asm/tlbflush_64.h
index f0d6a9700f4c..3c3c89f52643 100644
--- a/arch/sparc/include/asm/tlbflush_64.h
+++ b/arch/sparc/include/asm/tlbflush_64.h
@@ -1,7 +1,6 @@
#ifndef _SPARC64_TLBFLUSH_H
#define _SPARC64_TLBFLUSH_H
-#include <linux/mm.h>
#include <asm/mmu_context.h>
/* TSB flush operations. */
--
1.8.4.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sparc64: fix build regession
2013-11-18 9:44 [PATCH] sparc64: fix build regession Kirill A. Shutemov
@ 2013-11-18 23:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-11-18 23:08 UTC (permalink / raw)
To: kirill.shutemov; +Cc: geert, sfr, akpm, linux-kernel, linux-mm
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date: Mon, 18 Nov 2013 11:44:09 +0200
> Commit ea1e7ed33708 triggers build regression on sparc64.
>
> include/linux/mm.h:1391:2: error: implicit declaration of function 'pgtable_cache_init' [-Werror=implicit-function-declaration]
> arch/sparc/include/asm/pgtable_64.h:978:13: error: conflicting types for 'pgtable_cache_init' [-Werror]
>
> It happens due headers include loop:
>
> <linux/mm.h> -> <asm/pgtable.h> -> <asm/pgtable_64.h> ->
> <asm/tlbflush.h> -> <asm/tlbflush_64.h> -> <linux/mm.h>
>
> Let's drop <linux/mm.h> include from asm/tlbflush_64.h.
> Build tested with allmodconfig.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, please post sparc patches to sparclinux@vger.kernel.org in the
future so that I can properly track them.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-18 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-18 9:44 [PATCH] sparc64: fix build regession Kirill A. Shutemov
2013-11-18 23:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).