* [PATCH] mm/hwpoison: add '#' to hwpoison_inject
@ 2013-12-06 9:26 Wanpeng Li
2013-12-06 17:48 ` Naoya Horiguchi
2013-12-09 16:27 ` Vladimir Murzin
0 siblings, 2 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-12-06 9:26 UTC (permalink / raw)
To: Andrew Morton
Cc: Andi Kleen, Naoya Horiguchi, linux-mm, linux-kernel, Wanpeng Li
Add '#' to hwpoison_inject just as done in madvise_hwpoison.
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
mm/hwpoison-inject.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
index 4c84678..146cead 100644
--- a/mm/hwpoison-inject.c
+++ b/mm/hwpoison-inject.c
@@ -55,7 +55,7 @@ static int hwpoison_inject(void *data, u64 val)
return 0;
inject:
- printk(KERN_INFO "Injecting memory failure at pfn %lx\n", pfn);
+ pr_info(KERN_INFO "Injecting memory failure at pfn %#lx\n", pfn);
return memory_failure(pfn, 18, MF_COUNT_INCREASED);
}
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/hwpoison: add '#' to hwpoison_inject
2013-12-06 9:26 [PATCH] mm/hwpoison: add '#' to hwpoison_inject Wanpeng Li
@ 2013-12-06 17:48 ` Naoya Horiguchi
2013-12-09 16:27 ` Vladimir Murzin
1 sibling, 0 replies; 4+ messages in thread
From: Naoya Horiguchi @ 2013-12-06 17:48 UTC (permalink / raw)
To: Wanpeng Li; +Cc: Andrew Morton, Andi Kleen, linux-mm, linux-kernel
On Fri, Dec 06, 2013 at 05:26:53PM +0800, Wanpeng Li wrote:
> Add '#' to hwpoison_inject just as done in madvise_hwpoison.
>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
It could affect some test code, but I checked mce-test and it doesn't
depend on this message. So maybe it's OK.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Thanks,
Naoya
> ---
> mm/hwpoison-inject.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 4c84678..146cead 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -55,7 +55,7 @@ static int hwpoison_inject(void *data, u64 val)
> return 0;
>
> inject:
> - printk(KERN_INFO "Injecting memory failure at pfn %lx\n", pfn);
> + pr_info(KERN_INFO "Injecting memory failure at pfn %#lx\n", pfn);
> return memory_failure(pfn, 18, MF_COUNT_INCREASED);
> }
>
> --
> 1.7.7.6
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/hwpoison: add '#' to hwpoison_inject
2013-12-06 9:26 [PATCH] mm/hwpoison: add '#' to hwpoison_inject Wanpeng Li
2013-12-06 17:48 ` Naoya Horiguchi
@ 2013-12-09 16:27 ` Vladimir Murzin
2013-12-09 23:35 ` Wanpeng Li
1 sibling, 1 reply; 4+ messages in thread
From: Vladimir Murzin @ 2013-12-09 16:27 UTC (permalink / raw)
To: Wanpeng Li
Cc: Andrew Morton, Andi Kleen, Naoya Horiguchi, linux-mm,
linux-kernel
Hi Wanpeng
On Fri, Dec 06, 2013 at 05:26:53PM +0800, Wanpeng Li wrote:
> Add '#' to hwpoison_inject just as done in madvise_hwpoison.
>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> ---
> mm/hwpoison-inject.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 4c84678..146cead 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -55,7 +55,7 @@ static int hwpoison_inject(void *data, u64 val)
> return 0;
>
> inject:
> - printk(KERN_INFO "Injecting memory failure at pfn %lx\n", pfn);
> + pr_info(KERN_INFO "Injecting memory failure at pfn %#lx\n", pfn);
You don't need KERN_INFO here.
Vladimir
> return memory_failure(pfn, 18, MF_COUNT_INCREASED);
> }
>
> --
> 1.7.7.6
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/hwpoison: add '#' to hwpoison_inject
2013-12-09 16:27 ` Vladimir Murzin
@ 2013-12-09 23:35 ` Wanpeng Li
0 siblings, 0 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-12-09 23:35 UTC (permalink / raw)
To: Vladimir Murzin
Cc: Andrew Morton, Andi Kleen, Naoya Horiguchi, linux-mm,
linux-kernel
Hi Vladimir,
On Mon, Dec 09, 2013 at 05:27:27PM +0100, Vladimir Murzin wrote:
>Hi Wanpeng
>
>On Fri, Dec 06, 2013 at 05:26:53PM +0800, Wanpeng Li wrote:
>> Add '#' to hwpoison_inject just as done in madvise_hwpoison.
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>> mm/hwpoison-inject.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
>> index 4c84678..146cead 100644
>> --- a/mm/hwpoison-inject.c
>> +++ b/mm/hwpoison-inject.c
>> @@ -55,7 +55,7 @@ static int hwpoison_inject(void *data, u64 val)
>> return 0;
>>
>> inject:
>> - printk(KERN_INFO "Injecting memory failure at pfn %lx\n", pfn);
>> + pr_info(KERN_INFO "Injecting memory failure at pfn %#lx\n", pfn);
>
>You don't need KERN_INFO here.
>
Ah, indeed, I will fix it. Thanks.
Regards,
Wanpeng Li
>Vladimir
>
>> return memory_failure(pfn, 18, MF_COUNT_INCREASED);
>> }
>>
>> --
>> 1.7.7.6
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-09 23:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-06 9:26 [PATCH] mm/hwpoison: add '#' to hwpoison_inject Wanpeng Li
2013-12-06 17:48 ` Naoya Horiguchi
2013-12-09 16:27 ` Vladimir Murzin
2013-12-09 23:35 ` Wanpeng Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).