From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v4 07/12] sched/numa: fix set cpupid on page migration twice against normal page
Date: Tue, 10 Dec 2013 17:19:30 +0800 [thread overview]
Message-ID: <1386667175-19952-7-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386667175-19952-1-git-send-email-liwanp@linux.vnet.ibm.com>
commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
the cpupid at page migration time, there is unnecessary to set it again
in function alloc_misplaced_dst_page, this patch fix it.
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
mm/migrate.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index b1b6663..508cde4 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1557,8 +1557,6 @@ static struct page *alloc_misplaced_dst_page(struct page *page,
__GFP_NOMEMALLOC | __GFP_NORETRY |
__GFP_NOWARN) &
~GFP_IOFS, 0);
- if (newpage)
- page_cpupid_xchg_last(newpage, page_cpupid_last(page));
return newpage;
}
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-10 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 9:19 [PATCH v4 01/12] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 02/12] sched/numa: drop idx field of task_numa_env struct Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 03/12] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 04/12] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 05/12] sched/numa: make numamigrate_isolate_page static Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 06/12] sched/numa: make numamigrate_update_ratelimit static Wanpeng Li
2013-12-10 20:35 ` Naoya Horiguchi
2013-12-10 9:19 ` Wanpeng Li [this message]
2013-12-10 20:35 ` [PATCH v4 07/12] sched/numa: fix set cpupid on page migration twice against normal page Naoya Horiguchi
2013-12-10 9:19 ` [PATCH v4 08/12] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-10 20:36 ` Naoya Horiguchi
2013-12-10 9:19 ` [PATCH v4 09/12] sched/numa: fix period_slot recalculation Wanpeng Li
2013-12-10 20:37 ` Naoya Horiguchi
2013-12-10 9:19 ` [PATCH v4 10/12] sched/numa: fix record hinting faults check Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 11/12] sched/numa: drop unnecessary variable in task_weight Wanpeng Li
2013-12-10 9:19 ` [PATCH v4 12/12] sched/numa: fix two local 'ret' in task_numa_migrate() Wanpeng Li
2013-12-10 12:11 ` [PATCH v4 01/12] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-10 20:34 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386667175-19952-7-git-send-email-liwanp@linux.vnet.ibm.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).