From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by kanga.kvack.org (Postfix) with ESMTP id F13B96B0031 for ; Thu, 12 Dec 2013 02:24:05 -0500 (EST) Received: by mail-pd0-f177.google.com with SMTP id q10so16035pdj.36 for ; Wed, 11 Dec 2013 23:24:05 -0800 (PST) Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com. [202.81.31.148]) by mx.google.com with ESMTPS id g5si15734966pav.288.2013.12.11.23.24.03 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 11 Dec 2013 23:24:04 -0800 (PST) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Dec 2013 17:24:01 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id A53B52CE8053 for ; Thu, 12 Dec 2013 18:23:58 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBC75ZPZ38469742 for ; Thu, 12 Dec 2013 18:05:36 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBC7NvYO003108 for ; Thu, 12 Dec 2013 18:23:57 +1100 From: Wanpeng Li Subject: [PATCH v8 4/4] sched/numa: fix period_slot recalculation Date: Thu, 12 Dec 2013 15:23:26 +0800 Message-Id: <1386833006-6600-4-git-send-email-liwanp@linux.vnet.ibm.com> In-Reply-To: <1386833006-6600-1-git-send-email-liwanp@linux.vnet.ibm.com> References: <1386833006-6600-1-git-send-email-liwanp@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar , Peter Zijlstra Cc: Andrew Morton , Rik van Riel , Mel Gorman , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wanpeng Li Changelog: v3 -> v4: * remove period_slot recalculation The original code is as intended and was meant to scale the difference between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting the scan period. The period_slot recalculation can be dropped. Reviewed-by: Naoya Horiguchi Acked-by: Mel Gorman Acked-by: David Rientjes Signed-off-by: Wanpeng Li --- kernel/sched/fair.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8a00879..e7ca79a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p, * scanning faster if shared accesses dominate as it may * simply bounce migrations uselessly */ - period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS); ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared)); diff = (diff * ratio) / NUMA_PERIOD_SLOTS; } -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org