From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id B34586B003A for ; Fri, 13 Dec 2013 01:50:39 -0500 (EST) Received: by mail-pd0-f170.google.com with SMTP id g10so1933548pdj.15 for ; Thu, 12 Dec 2013 22:50:39 -0800 (PST) Received: from LGEAMRELO02.lge.com (lgeamrelo02.lge.com. [156.147.1.126]) by mx.google.com with ESMTP id sg3si756449pbb.253.2013.12.12.22.50.36 for ; Thu, 12 Dec 2013 22:50:38 -0800 (PST) From: Joonsoo Kim Subject: [PATCH v3 5/6] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Date: Fri, 13 Dec 2013 15:53:30 +0900 Message-Id: <1386917611-11319-6-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1386917611-11319-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1386917611-11319-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Wanpeng Li , Joonsoo Kim update_pageblock_skip() only fits to compaction which tries to isolate by pageblock unit. If isolate_migratepages_range() is called by CMA, it try to isolate regardless of pageblock unit and it don't reference get_pageblock_skip() by ignore_skip_hint. We should also respect it on update_pageblock_skip() to prevent from setting the wrong information. Cc: # 3.7+ Acked-by: Vlastimil Babka Reviewed-by: Naoya Horiguchi Reviewed-by: Wanpeng Li Signed-off-by: Joonsoo Kim diff --git a/mm/compaction.c b/mm/compaction.c index 805165b..f58bcd0 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -134,6 +134,10 @@ static void update_pageblock_skip(struct compact_control *cc, bool migrate_scanner) { struct zone *zone = cc->zone; + + if (cc->ignore_skip_hint) + return; + if (!page) return; -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org