[PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix

[PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix

[Sasha Levin]

I messed up and forgot to commit this fix before sending out the original
patch.

It fixes build issues in various files using VM_BUG_ON_PAGE.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 include/linux/mmdebug.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index e522734..8bb6490 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
 #define LINUX_MM_DEBUG_H 1
 
 #ifdef CONFIG_DEBUG_VM
+extern void dump_page(struct page *page);
 #define VM_BUG_ON(cond) BUG_ON(cond)
 #define VM_BUG_ON_PAGE(cond, page) \
 	do { if (unlikely(cond)) { dump_page(page); BUG(); } } while(0)
-- 
1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix

[Kirill A. Shutemov]

On Fri, Dec 27, 2013 at 05:40:18PM -0500, Sasha Levin wrote:
> I messed up and forgot to commit this fix before sending out the original
> patch.
> 
> It fixes build issues in various files using VM_BUG_ON_PAGE.

With the patch applied I see this:

  CC      kernel/bounds.s
In file included from /home/space/kas/git/public/linux-next/include/linux/page-flags.h:10:0,
                 from /home/space/kas/git/public/linux-next/kernel/bounds.c:9:
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: a??struct pagea?? declared inside parameter list [enabled by default]
 extern void dump_page(struct page *page);
                              ^
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

We need to declare struct page here as well.

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 8bb64900da25..e8cec8bdda05 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
 #define LINUX_MM_DEBUG_H 1
 
 #ifdef CONFIG_DEBUG_VM
+struct page;
 extern void dump_page(struct page *page);
 #define VM_BUG_ON(cond) BUG_ON(cond)
 #define VM_BUG_ON_PAGE(cond, page) \
-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>