From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE246CEF17C for ; Tue, 8 Oct 2024 14:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55ABE6B007B; Tue, 8 Oct 2024 10:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E1DD6B0082; Tue, 8 Oct 2024 10:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30D946B0083; Tue, 8 Oct 2024 10:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D5416B007B for ; Tue, 8 Oct 2024 10:12:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BB951201BE for ; Tue, 8 Oct 2024 14:12:25 +0000 (UTC) X-FDA: 82650625092.28.631D043 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id E81754000A for ; Tue, 8 Oct 2024 14:12:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwZ3E1Mj; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728396675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ozbo2hzDtlCgJZ17rzvPUNm8K0QrGHUxAVJmODFHMGk=; b=AVmrSwJMrwlg8g9z3KmPenH1XzQbcFTL7w8lH/coHQ/a8vXXFoedkkg2dwjUj4C7HA+zwZ m/nnpQSitAvJgYVxd3rIVhbpqhmJuDz//CPf0HWpQ15OYbHfMlBGVtytiALCyPbMVv1OH8 B4tlw5xVmDm2yu5sXD4QZlexJb+c6kc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwZ3E1Mj; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728396675; a=rsa-sha256; cv=none; b=4MISU9Kw32NJ4ZyDp5fTrMqwF+Yooq3ftaz+3EOqeru5tW+LwiJiuEM54+4rQCxKNVVRn0 mWBvKmXgCyxpNUkJmM0QfrFZOJcut0ZvQrEDySsZmFDXz8RO5Fs6c4H1WoMTTTE/2DqfV5 68qdglxEV+tfsuLX70be0+wb2Aa08pM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728396743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ozbo2hzDtlCgJZ17rzvPUNm8K0QrGHUxAVJmODFHMGk=; b=GwZ3E1MjTUvjI6yUkzH8VDxvmheFJuWxycscb8zW9yrmB+w01d5S5p3dhJS9XfTR/q6yyR +C+lQCh8Gynw/HHWxZuoHycH2vPLY6atk6AwRZ7K37QcM0cL3gDbCuYLqDa0EzxWeFGqWY U0Yyd85wBx8bDNoUkJtyAlZpvWPLqjM= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-Aw0nsdjKMs2i60VyDk1Eww-1; Tue, 08 Oct 2024 10:12:17 -0400 X-MC-Unique: Aw0nsdjKMs2i60VyDk1Eww-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5389ef4c213so4994522e87.3 for ; Tue, 08 Oct 2024 07:12:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728396736; x=1729001536; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ozbo2hzDtlCgJZ17rzvPUNm8K0QrGHUxAVJmODFHMGk=; b=KzJltuDECuWIbP11yxwxQxKk5CilkEQ47XYZbqA90QlEN+K3VQdXU0RItg2FQEapp1 4+dkMJsdg3uiuhT6PGKIeG+fCJSt8HzaMbPXFxxFvSH3bT4fhR2NMQ6rztV5ilX0613z vGWiw4nqSxk/PT1FDQLhOLMhS+V5WI4IjYoBCLbL87jOW9GZvKzMTL+yw2Bp9IImuDkk HI8tnYU2Yj7X0BkqHXf6uIej/zQTC0fEqo09YxDs7+8fxGwEFfdi3BM2Xtutt4x51Ijz texe2H0x9la38uoMUSgFJhzqeXs3qxe5lItvKRS0CQt3yuVmMmwvh43nncuZb2F6jAZG dqBQ== X-Forwarded-Encrypted: i=1; AJvYcCUUyGYNxSZn0+ak8eGIHhiPPsi1knDiq2jdzW/Mu3NehYtdl2U/SYYUJtVy/YScVCt+LewY+NSWlQ==@kvack.org X-Gm-Message-State: AOJu0YwbnPLKeQ25sK0gpWh/dB6exdq5xW5Y24O2V0DpLSKdpDkl2bR6 SmXdWuviRK1xIPI+3ru5sAV6SJza/rzwm6mcZh6EfMw9vnVW/HpZxY/TB9FP8LsQ0xQTWaUtNMA xrNXrmBIKKi7YxQlqHdCJQUAuL3/d0Ay5QdBDgz8fKd9l4HEoCnefqzso968= X-Received: by 2002:a05:6512:3ba8:b0:52e:f99e:5dd1 with SMTP id 2adb3069b0e04-539ab8adfa0mr8057993e87.47.1728396735984; Tue, 08 Oct 2024 07:12:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgrbIw8PRQ0g3RZoClc90Tbh5vm0gX4BaPBKQ4MoCISVt3i62XazClu7z9WkXid93d4XSNAQ== X-Received: by 2002:a05:6512:3ba8:b0:52e:f99e:5dd1 with SMTP id 2adb3069b0e04-539ab8adfa0mr8057970e87.47.1728396735423; Tue, 08 Oct 2024 07:12:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:c700:a76f:473d:d5cf:25a8? (p200300cbc72fc700a76f473dd5cf25a8.dip0.t-ipconnect.de. [2003:cb:c72f:c700:a76f:473d:d5cf:25a8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86b4b0bfsm128298375e9.48.2024.10.08.07.12.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 07:12:14 -0700 (PDT) Message-ID: <1390d267-9a32-4904-bca3-02814ee8e387@redhat.com> Date: Tue, 8 Oct 2024 16:12:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gup: Convert FOLL_TOUCH case in follow_page_pte() to folio To: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org References: <20241002151403.1345296-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241002151403.1345296-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E81754000A X-Stat-Signature: e3cpbw9pp5b3yhttnfoerr3mzorddro3 X-HE-Tag: 1728396743-180044 X-HE-Meta: U2FsdGVkX1/w4m8XjYJw+aRCGvzvmFlcWjHvPNiiS3eM8qX/92Y1QV23AcxlV76FTnb0sw4KMaibTfjZLZ0LL2GBaQP5huJzoROWXJM21E4tmWpjS3PZBo5t0Nb5m+XrpekPMGlCIiufgqTmUlIu7mfkRdrss9dsERdxn92Ec/NXLTNeWIOVrTKlfUES6i0hKsioY7HZ9hXrvibyYjs9CP6UF2MZeGIt9GxqGo8XcD0INSViCXdSYpDW4xMPVe2IELOZo5bmJTBzVjsu3Kr0odFW9fkOGIzPGAoQa3ysEqWfltOoIXWnhy1OdvgKirJR4cuUFxX63NPNTVI2Xg9A/tMAby1Z1chNdMirHZf3o1LXHtYIzr9bgFigCui4dTTj/+T0EQ6GH5QK1ar9Yx6Gbk3DOVw4fC3pD2tiWk+33cn/8GeXwOttAzQFFWNAIdLV+N25OKs0XUl4e/SF92Kfqs/b1TihEAs03/b76aaT8/Q7PpJKEmCjQnoDgJ0LNuS54iUavoHJF/jDtixBCJirQe8bX3MzN+Zy1N038P4WtUx+YSihwAz/UFkYXvwFMX2oUm2QH8PKON8e+7/lCTEsMkhlifNtt/LkJ6d41k12GS3zxMXsILue7BvBDZedNiIa5a2yqyU4sKtCAb0H6dUtKIObCg/6vf3qVF/jnQKB8XQSBnT1uCWUmZ5LSPhIEBL1IKp64h/7th06K/x8O8Y57YRbcXiaoaj8pvxjPYR7A4ymuB40o5xJu8Pg3LA24V6jyrv6px1o4EarpvPHAoIi1it6EHkTjueaslpgKOVOiv5Sz49W534bB21d9vXTrtc7un0BlvrImpX8ur31itA24ThCd6jUhxf0zsaoJVL/BzTD5Ys7871m5SHR7PDtoWUzSO9zQ3HWQUSa1axDo5/cLU9pzi0PZVE5pU527Ueq6dFyQeFF33n73KXVGrhlXU8bd1PvWinxhKUSxGu8qxq 7iGcBimQ K8lKlWtfvC4Fl0MAU/D2iEHX+MbnXjMiJKS4G2v+QxfbiM4faDM5RByAiUJAMIIPxxGevFNnfwegB9JLLrKKBFNYj8Cq3pvG9eO+oHTXzhWN91Ddma6ie1v4zPA//KbeUpcmqTlQR83u55ZoVsA3p9pmVw8+L/FPVLsiC52riFFLdC9vbWmIZNP4FvQr4Bz8Jc23EOnnd6NnX+FLBeAUdzR5X4D01PU2jCdSBAWAtp4NOAVRsSYov24lcaG5ESIm6oS/pVEPa3BSe6ygubRJnSMlfOX8OEZF7/ATprWsi9fu9qamB4Wlwa7CtQJ3H84eC/uaAHm8LIYu+O4q/dAUAJXJWVLfUd7AAElhyFbRmltXvOfhY7GH4M3yKXkPc74pRUPNonIxsK2CArocSRMXNqek4iSahVxc+ItdcsQFnsWNoiGn8JiCoMuw8NDKT0rSW2BiENU31r0Bo41fZjmUmqyz9eDLgUDhmiZa7VVwXFCBad27Xgpt8eqkFYASoXpYXPitqZ91bZnHPcvV4fwWfqDmxlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.10.24 17:13, Matthew Wilcox (Oracle) wrote: > We already have the folio here, so just use it, removing three hidden > calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/gup.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index a82890b46a36..7aecaa5ff6f3 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -922,14 +922,14 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, > } > if (flags & FOLL_TOUCH) { > if ((flags & FOLL_WRITE) && > - !pte_dirty(pte) && !PageDirty(page)) > - set_page_dirty(page); > + !pte_dirty(pte) && !folio_test_dirty(folio)) > + folio_mark_dirty(folio); > /* > * pte_mkyoung() would be more correct here, but atomic care > * is needed to avoid losing the dirty bit: it is easier to use > - * mark_page_accessed(). > + * folio_mark_accessed(). > */ > - mark_page_accessed(page); > + folio_mark_accessed(folio); > } > out: > pte_unmap_unlock(ptep, ptl); Acked-by: David Hildenbrand -- Cheers, David / dhildenb