From: Luiz Capitulino <lcapitulino@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mtosatti@redhat.com, mgorman@suse.de, aarcange@redhat.com,
andi@firstfloor.org, riel@redhat.com
Subject: [PATCH 1/4] memblock: memblock_virt_alloc_internal(): alloc from specified node only
Date: Mon, 10 Feb 2014 12:27:45 -0500 [thread overview]
Message-ID: <1392053268-29239-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1392053268-29239-1-git-send-email-lcapitulino@redhat.com>
From: Luiz capitulino <lcapitulino@redhat.com>
If an allocation from the node specified by the nid argument fails,
memblock_virt_alloc_internal() automatically tries to allocate memory
from other nodes.
This is fine is the caller don't care which node is going to allocate
the memory. However, there are cases where the caller wants memory to
be allocated from the specified node only. If that's not possible, then
memblock_virt_alloc_internal() should just fail.
This commit adds a new flags argument to memblock_virt_alloc_internal()
where the caller can control this behavior.
Signed-off-by: Luiz capitulino <lcapitulino@redhat.com>
---
mm/memblock.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 39a31e7..b0c7b2e 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1028,6 +1028,8 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i
return memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE);
}
+#define ALLOC_SPECIFIED_NODE_ONLY 0x1
+
/**
* memblock_virt_alloc_internal - allocate boot memory block
* @size: size of memory block to be allocated in bytes
@@ -1058,7 +1060,7 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i
static void * __init memblock_virt_alloc_internal(
phys_addr_t size, phys_addr_t align,
phys_addr_t min_addr, phys_addr_t max_addr,
- int nid)
+ int nid, unsigned int flags)
{
phys_addr_t alloc;
void *ptr;
@@ -1085,6 +1087,8 @@ again:
nid);
if (alloc)
goto done;
+ else if (flags & ALLOC_SPECIFIED_NODE_ONLY)
+ goto error;
if (nid != NUMA_NO_NODE) {
alloc = memblock_find_in_range_node(size, align, min_addr,
@@ -1145,7 +1149,7 @@ void * __init memblock_virt_alloc_try_nid_nopanic(
__func__, (u64)size, (u64)align, nid, (u64)min_addr,
(u64)max_addr, (void *)_RET_IP_);
return memblock_virt_alloc_internal(size, align, min_addr,
- max_addr, nid);
+ max_addr, nid, 0);
}
/**
@@ -1177,7 +1181,7 @@ void * __init memblock_virt_alloc_try_nid(
__func__, (u64)size, (u64)align, nid, (u64)min_addr,
(u64)max_addr, (void *)_RET_IP_);
ptr = memblock_virt_alloc_internal(size, align,
- min_addr, max_addr, nid);
+ min_addr, max_addr, nid, 0);
if (ptr)
return ptr;
--
1.8.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-10 17:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 17:27 [PATCH 0/4] hugetlb: add hugepagesnid= command-line option Luiz Capitulino
2014-02-10 17:27 ` Luiz Capitulino [this message]
2014-02-10 23:27 ` [PATCH 1/4] memblock: memblock_virt_alloc_internal(): alloc from specified node only Andrew Morton
2014-02-11 9:20 ` Mel Gorman
2014-02-10 17:27 ` [PATCH 2/4] memblock: add memblock_virt_alloc_nid_nopanic() Luiz Capitulino
2014-02-10 17:27 ` [PATCH 3/4] hugetlb: add hugepagesnid= command-line option Luiz Capitulino
2014-02-10 23:27 ` Andrew Morton
2014-02-11 15:26 ` Luiz Capitulino
2014-02-12 3:44 ` Yasuaki Ishimatsu
2014-02-12 19:39 ` Luiz Capitulino
2014-02-10 17:27 ` [PATCH 4/4] hugetlb: hugepagesnid=: add 1G huge page support Luiz Capitulino
2014-02-10 23:30 ` Andrew Morton
2014-02-11 15:27 ` Luiz Capitulino
2014-02-10 17:55 ` [PATCH 0/4] hugetlb: add hugepagesnid= command-line option Luiz Capitulino
2014-02-10 23:13 ` Andrew Morton
2014-02-11 3:58 ` Davidlohr Bueso
2014-02-11 15:10 ` Luiz Capitulino
2014-02-11 2:54 ` David Rientjes
2014-02-11 9:25 ` Mel Gorman
2014-02-11 15:26 ` Marcelo Tosatti
2014-02-11 17:10 ` Mel Gorman
2014-02-11 20:15 ` Marcelo Tosatti
2014-02-12 10:39 ` Mel Gorman
2014-02-11 15:36 ` Luiz Capitulino
2014-02-12 3:59 ` David Rientjes
2014-02-12 20:09 ` Luiz Capitulino
2014-02-11 21:17 ` Andi Kleen
2014-02-11 21:31 ` Luiz Capitulino
2014-02-12 2:37 ` Andi Kleen
2014-02-12 4:01 ` David Rientjes
2014-02-12 19:33 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392053268-29239-2-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).