From: Luiz Capitulino <lcapitulino@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mtosatti@redhat.com, mgorman@suse.de, aarcange@redhat.com,
andi@firstfloor.org, riel@redhat.com, davidlohr@hp.com,
isimatu.yasuaki@jp.fujitsu.com, yinghai@kernel.org,
rientjes@google.com
Subject: [PATCH 1/4] memblock: memblock_virt_alloc_internal(): add __GFP_THISNODE flag support
Date: Thu, 13 Feb 2014 20:02:05 -0500 [thread overview]
Message-ID: <1392339728-13487-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1392339728-13487-1-git-send-email-lcapitulino@redhat.com>
From: Luiz capitulino <lcapitulino@redhat.com>
Currently, if an allocation from the node specified by the nid argument
fails, memblock_virt_alloc_internal() automatically tries to allocate memory
from other nodes.
This is fine if the caller don't care about which node is going to allocate
the memory. However, there are cases where the caller wants memory to be
allocated from the specified node only. If that's not possible, then
memblock_virt_alloc_internal() should just fail.
This commit adds a new flags argument to memblock_virt_alloc_internal()
where the caller can control this behavior. The flags argument is of type
gfp_t, so that we can (re-)use the __GFP_THISNODE definition.
Signed-off-by: Luiz capitulino <lcapitulino@redhat.com>
---
mm/memblock.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 39a31e7..f3821ef 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1035,12 +1035,18 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i
* @min_addr: the lower bound of the memory region to allocate (phys address)
* @max_addr: the upper bound of the memory region to allocate (phys address)
* @nid: nid of the free area to find, %NUMA_NO_NODE for any node
+ * @flags: control how memory is allocated
*
* The @min_addr limit is dropped if it can not be satisfied and the allocation
* will fall back to memory below @min_addr. Also, allocation may fall back
* to any node in the system if the specified node can not
* hold the requested memory.
*
+ * The @flags argument is one of:
+ *
+ * %__GFP_THISNODE: memory is allocated from the node specified by @nid only.
+ * If that fails, an error is returned
+ *
* The allocation is performed from memory region limited by
* memblock.current_limit if @max_addr == %BOOTMEM_ALLOC_ACCESSIBLE.
*
@@ -1058,7 +1064,7 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i
static void * __init memblock_virt_alloc_internal(
phys_addr_t size, phys_addr_t align,
phys_addr_t min_addr, phys_addr_t max_addr,
- int nid)
+ int nid, gfp_t flags)
{
phys_addr_t alloc;
void *ptr;
@@ -1085,6 +1091,8 @@ again:
nid);
if (alloc)
goto done;
+ if (flags & __GFP_THISNODE)
+ goto error;
if (nid != NUMA_NO_NODE) {
alloc = memblock_find_in_range_node(size, align, min_addr,
@@ -1145,7 +1153,7 @@ void * __init memblock_virt_alloc_try_nid_nopanic(
__func__, (u64)size, (u64)align, nid, (u64)min_addr,
(u64)max_addr, (void *)_RET_IP_);
return memblock_virt_alloc_internal(size, align, min_addr,
- max_addr, nid);
+ max_addr, nid, 0);
}
/**
@@ -1177,7 +1185,7 @@ void * __init memblock_virt_alloc_try_nid(
__func__, (u64)size, (u64)align, nid, (u64)min_addr,
(u64)max_addr, (void *)_RET_IP_);
ptr = memblock_virt_alloc_internal(size, align,
- min_addr, max_addr, nid);
+ min_addr, max_addr, nid, 0);
if (ptr)
return ptr;
--
1.8.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-14 1:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 1:02 [PATCH v2 0/4] hugetlb: add hugepages_node= command-line option Luiz Capitulino
2014-02-14 1:02 ` Luiz Capitulino [this message]
2014-02-14 1:02 ` [PATCH 2/4] memblock: add memblock_virt_alloc_nid_nopanic() Luiz Capitulino
2014-02-14 1:02 ` [PATCH 3/4] hugetlb: add parse_pagesize_str() Luiz Capitulino
2014-02-14 1:02 ` [PATCH 4/4] hugetlb: add hugepages_node= command-line option Luiz Capitulino
2014-02-14 23:14 ` David Rientjes
2014-02-15 3:58 ` Luiz Capitulino
2014-02-15 10:06 ` David Rientjes
2014-02-17 13:56 ` Luiz Capitulino
2014-02-17 23:23 ` David Rientjes
2014-02-18 12:30 ` Marcelo Tosatti
2014-02-18 22:16 ` David Rientjes
2014-02-20 2:22 ` Marcelo Tosatti
2014-02-20 3:46 ` David Rientjes
2014-02-20 4:42 ` Luiz Capitulino
2014-02-20 4:51 ` David Rientjes
2014-02-20 15:06 ` Luiz Capitulino
2014-02-20 21:34 ` Marcelo Tosatti
2014-02-20 23:15 ` David Rientjes
2014-02-21 2:28 ` Marcelo Tosatti
2014-02-21 10:07 ` David Rientjes
2014-02-21 19:10 ` Marcelo Tosatti
2014-02-21 22:04 ` David Rientjes
2014-02-21 22:36 ` Andi Kleen
2014-02-21 22:44 ` David Rientjes
2014-02-21 22:55 ` Andi Kleen
2014-02-21 3:35 ` Luiz Capitulino
2014-02-20 21:38 ` Marcelo Tosatti
2014-02-20 23:17 ` David Rientjes
2014-02-18 5:47 ` Davidlohr Bueso
2014-02-21 23:54 ` Andrew Morton
2014-02-22 4:03 ` Andi Kleen
2014-02-22 4:31 ` Davidlohr Bueso
2014-02-22 4:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392339728-13487-2-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davidlohr@hp.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).