From: riel@redhat.com
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org,
chegu_vinod@hp.com, aarcange@redhat.com,
akpm@linux-foundation.org
Subject: [PATCH -mm 1/3] sched,numa: add cond_resched to task_numa_work
Date: Tue, 18 Feb 2014 17:12:44 -0500 [thread overview]
Message-ID: <1392761566-24834-2-git-send-email-riel@redhat.com> (raw)
In-Reply-To: <1392761566-24834-1-git-send-email-riel@redhat.com>
From: Rik van Riel <riel@redhat.com>
Normally task_numa_work scans over a fairly small amount of memory,
but it is possible to run into a large unpopulated part of virtual
memory, with no pages mapped. In that case, task_numa_work can run
for a while, and it may make sense to reschedule as required.
Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Reported-by: Xing Gang <gang.xing@hp.com>
Tested-by: Chegu Vinod <chegu_vinod@hp.com>
---
kernel/sched/fair.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 966cc2b..7815709 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1757,6 +1757,8 @@ void task_numa_work(struct callback_head *work)
start = end;
if (pages <= 0)
goto out;
+
+ cond_resched();
} while (end != vma->vm_end);
}
--
1.8.5.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-18 22:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:12 [PATCH -mm 0/3] fix numa vs kvm scalability issue riel
2014-02-18 22:12 ` riel [this message]
2014-02-18 22:12 ` [PATCH -mm 2/3] mm,numa: reorganize change_pmd_range riel
2014-02-19 2:22 ` David Rientjes
2014-02-18 22:12 ` [PATCH -mm 3/3] move mmu notifier call from change_protection to change_pmd_range riel
2014-02-19 2:24 ` David Rientjes
2014-02-19 3:08 ` Rik van Riel
2014-02-19 3:18 ` [PATCH -mm v2 " Rik van Riel
2014-02-19 8:59 ` [PATCH -mm 0/3] fix numa vs kvm scalability issue Peter Zijlstra
2014-02-19 19:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392761566-24834-2-git-send-email-riel@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chegu_vinod@hp.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).