linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	Mel Gorman <mgorman@suse.de>, Peter Anvin <hpa@zytor.com>,
	Ingo Molnar <mingo@kernel.org>,
	Steven Noonan <steven@uplinklabs.net>,
	Rik van Riel <riel@redhat.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Linux-MM <linux-mm@kvack.org>, Linux-X86 <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] mm: Allow FOLL_NUMA on FOLL_FORCE
Date: Mon,  7 Apr 2014 16:10:43 +0100	[thread overview]
Message-ID: <1396883443-11696-4-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1396883443-11696-1-git-send-email-mgorman@suse.de>

As _PAGE_NUMA is no longer aliased to _PAGE_PROTNONE there should be no
confusion between them. It should be possible to kick away the special
casing in __get_user_pages.

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/memory.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 22dfa61..b9c35a7 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1714,18 +1714,6 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 	vm_flags &= (gup_flags & FOLL_FORCE) ?
 			(VM_MAYREAD | VM_MAYWRITE) : (VM_READ | VM_WRITE);
 
-	/*
-	 * If FOLL_FORCE and FOLL_NUMA are both set, handle_mm_fault
-	 * would be called on PROT_NONE ranges. We must never invoke
-	 * handle_mm_fault on PROT_NONE ranges or the NUMA hinting
-	 * page faults would unprotect the PROT_NONE ranges if
-	 * _PAGE_NUMA and _PAGE_PROTNONE are sharing the same pte/pmd
-	 * bitflag. So to avoid that, don't set FOLL_NUMA if
-	 * FOLL_FORCE is set.
-	 */
-	if (!(gup_flags & FOLL_FORCE))
-		gup_flags |= FOLL_NUMA;
-
 	i = 0;
 
 	do {
-- 
1.8.4.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2014-04-07 15:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 15:10 [RFC PATCH 0/3] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA Mel Gorman
2014-04-07 15:10 ` [PATCH 1/3] x86: Require x86-64 for automatic NUMA balancing Mel Gorman
2014-04-07 15:10 ` [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels Mel Gorman
2014-04-07 15:32   ` David Vrabel
2014-04-07 15:49     ` Mel Gorman
2014-04-07 16:19       ` Cyrill Gorcunov
2014-04-07 18:28         ` Mel Gorman
2014-04-07 19:16           ` Cyrill Gorcunov
2014-04-07 19:27           ` H. Peter Anvin
2014-04-07 19:36             ` Cyrill Gorcunov
2014-04-07 19:42               ` H. Peter Anvin
2014-04-07 21:25                 ` Mel Gorman
2014-04-08  4:04                   ` Steven Noonan
2014-04-08 15:16                     ` H. Peter Anvin
2014-04-08 16:02                       ` Konrad Rzeszutek Wilk
2014-04-08 16:16                         ` H. Peter Anvin
2014-04-08 16:47                           ` Mel Gorman
2014-04-08 16:50                           ` David Vrabel
2014-04-08 16:51                         ` Mel Gorman
2014-04-09 15:18                           ` Konrad Rzeszutek Wilk
2014-04-09 15:39                             ` Mel Gorman
2014-04-08 20:51                       ` Steven Noonan
2014-04-08 20:59                         ` H. Peter Anvin
2014-04-09 15:04                           ` Konrad Rzeszutek Wilk
2014-04-09 15:09                             ` Peter Zijlstra
2014-04-08  9:31               ` David Vrabel
2014-04-07 21:19             ` Mel Gorman
2014-04-07 17:37   ` Dave Hansen
2014-04-07 15:10 ` Mel Gorman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396883443-11696-4-git-send-email-mgorman@suse.de \
    --to=mgorman@suse.de \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.vrabel@citrix.com \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=steven@uplinklabs.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).