From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by kanga.kvack.org (Postfix) with ESMTP id CA1F96B005A for ; Fri, 11 Apr 2014 16:15:58 -0400 (EDT) Received: by mail-pa0-f42.google.com with SMTP id fb1so5868308pad.29 for ; Fri, 11 Apr 2014 13:15:58 -0700 (PDT) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by mx.google.com with ESMTPS id ua2si4846251pab.200.2014.04.11.13.15.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Apr 2014 13:15:58 -0700 (PDT) Received: by mail-pd0-f169.google.com with SMTP id fp1so5683546pdb.14 for ; Fri, 11 Apr 2014 13:15:57 -0700 (PDT) From: John Stultz Subject: [PATCH 3/4] mvolatile: Add purged page detection on setting memory non-volatile Date: Fri, 11 Apr 2014 13:15:39 -0700 Message-Id: <1397247340-3365-4-git-send-email-john.stultz@linaro.org> In-Reply-To: <1397247340-3365-1-git-send-email-john.stultz@linaro.org> References: <1397247340-3365-1-git-send-email-john.stultz@linaro.org> Sender: owner-linux-mm@kvack.org List-ID: To: LKML Cc: John Stultz , Andrew Morton , Android Kernel Team , Johannes Weiner , Robert Love , Mel Gorman , Hugh Dickins , Dave Hansen , Rik van Riel , Dmitry Adamushko , Neil Brown , Andrea Arcangeli , Mike Hommey , Taras Glek , Jan Kara , KOSAKI Motohiro , Michel Lespinasse , Minchan Kim , Keith Packard , "linux-mm@kvack.org" Users of volatile ranges will need to know if memory was discarded. This patch adds the purged state tracking required to inform userland when it marks memory as non-volatile that some memory in that range was purged and needs to be regenerated. This simplified implementation which uses some of the logic from Minchan's earlier efforts, so credit to Minchan for his work. Cc: Andrew Morton Cc: Android Kernel Team Cc: Johannes Weiner Cc: Robert Love Cc: Mel Gorman Cc: Hugh Dickins Cc: Dave Hansen Cc: Rik van Riel Cc: Dmitry Adamushko Cc: Neil Brown Cc: Andrea Arcangeli Cc: Mike Hommey Cc: Taras Glek Cc: Jan Kara Cc: KOSAKI Motohiro Cc: Michel Lespinasse Cc: Minchan Kim Cc: Keith Packard Cc: linux-mm@kvack.org Acked-by: Jan Kara Signed-off-by: John Stultz --- include/linux/swap.h | 5 +++ include/linux/swapops.h | 10 ++++++ mm/mvolatile.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 101 insertions(+) diff --git a/include/linux/swap.h b/include/linux/swap.h index a90ea95..c372ca7 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -55,6 +55,7 @@ enum { * 1< #include #include +#include +#include #include "internal.h" +struct mvolatile_walker { + struct vm_area_struct *vma; + int page_was_purged; +}; + + +/** + * mvolatile_check_purged_pte - Checks ptes for purged pages + * @pmd: pmd to walk + * @addr: starting address + * @end: end address + * @walk: mm_walk ptr (contains ptr to mvolatile_walker) + * + * Iterates over the ptes in the pmd checking if they have + * purged swap entries. + * + * Sets the mvolatile_walker.page_was_purged to 1 if any were purged. + */ +static int mvolatile_check_purged_pte(pmd_t *pmd, unsigned long addr, + unsigned long end, struct mm_walk *walk) +{ + struct mvolatile_walker *vw = walk->private; + pte_t *pte; + spinlock_t *ptl; + int ret = 0; + + if (pmd_trans_huge(*pmd)) + return 0; + if (pmd_trans_unstable(pmd)) + return 0; + + pte = pte_offset_map_lock(walk->mm, pmd, addr, &ptl); + for (; addr != end; pte++, addr += PAGE_SIZE) { + if (!pte_present(*pte)) { + swp_entry_t mvolatile_entry = pte_to_swp_entry(*pte); + + if (unlikely(is_purged_entry(mvolatile_entry))) { + + vw->page_was_purged = 1; + + /* clear the pte swp entry */ + flush_cache_page(vw->vma, addr, pte_pfn(*pte)); + ptep_clear_flush(vw->vma, addr, pte); + } + } + } + pte_unmap_unlock(pte - 1, ptl); + cond_resched(); + + return ret; +} + + +/** + * mvolatile_check_purged - Sets up a mm_walk to check for purged pages + * @vma: ptr to vma we're starting with + * @start: start address to walk + * @end: end address of walk + * + * Sets up and calls wa_page_range() to check for purge pages. + * + * Returns 1 if pages in the range were purged, 0 otherwise. + */ +static int mvolatile_check_purged(struct vm_area_struct *vma, + unsigned long start, + unsigned long end) +{ + struct mvolatile_walker vw; + struct mm_walk mvolatile_walk = { + .pmd_entry = mvolatile_check_purged_pte, + .mm = vma->vm_mm, + .private = &vw, + }; + vw.page_was_purged = 0; + vw.vma = vma; + + walk_page_range(start, end, &mvolatile_walk); + + return vw.page_was_purged; + +} /** * do_mvolatile - Marks or clears VMAs in the range (start-end) as VM_VOLATILE @@ -119,6 +202,9 @@ success: vma = prev->vm_next; } out: + if (count && (mode == MVOLATILE_NONVOLATILE)) + *purged = mvolatile_check_purged(vma, orig_start, + orig_start+count); up_write(&mm->mmap_sem); /* report bytes successfully marked, even if we're exiting on error */ -- 1.8.3.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org