* [PATCH] percpu: make pcpu_alloc_chunk() use pcpu_mem_free() instead of kfree()
@ 2014-04-14 5:47 Jianyu Zhan
2014-04-14 20:21 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Jianyu Zhan @ 2014-04-14 5:47 UTC (permalink / raw)
To: tj, cl; +Cc: linux-mm, linux-kernel, nasa4836
pcpu_chunk_struct_size = sizeof(struct pcpu_chunk) +
BITS_TO_LONGS(pcpu_unit_pages) * sizeof(unsigned long)
It hardly could be ever bigger than PAGE_SIZE even for large-scale machine,
but for consistency with its couterpart pcpu_mem_zalloc(),
use pcpu_mem_free() instead.
Commit b4916cb17c261a6043bcb2a98d0d6512497a7cf8 addressed this
problem, but missed this one.
Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
---
mm/percpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index 63e24fb..2ddf9a9 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -610,7 +610,7 @@ static struct pcpu_chunk *pcpu_alloc_chunk(void)
chunk->map = pcpu_mem_zalloc(PCPU_DFL_MAP_ALLOC *
sizeof(chunk->map[0]));
if (!chunk->map) {
- kfree(chunk);
+ pcpu_mem_free(chunk, pcpu_chunk_struct_size);
return NULL;
}
--
1.9.0.GIT
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] percpu: make pcpu_alloc_chunk() use pcpu_mem_free() instead of kfree()
2014-04-14 5:47 [PATCH] percpu: make pcpu_alloc_chunk() use pcpu_mem_free() instead of kfree() Jianyu Zhan
@ 2014-04-14 20:21 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-04-14 20:21 UTC (permalink / raw)
To: Jianyu Zhan; +Cc: cl, linux-mm, linux-kernel
Applied to percpu/for-3.15-fixes with slightly updated commit message.
Thanks.
------- 8< -------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-14 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-14 5:47 [PATCH] percpu: make pcpu_alloc_chunk() use pcpu_mem_free() instead of kfree() Jianyu Zhan
2014-04-14 20:21 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).