From: Catalin Marinas <catalin.marinas@arm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: [PATCH 3/6] lib: Update the kmemleak stack trace for radix tree allocations
Date: Fri, 2 May 2014 14:41:07 +0100 [thread overview]
Message-ID: <1399038070-1540-4-git-send-email-catalin.marinas@arm.com> (raw)
In-Reply-To: <1399038070-1540-1-git-send-email-catalin.marinas@arm.com>
Since radix_tree_preload() stack trace is not always useful for
debugging an actual radix tree memory leak, this patch updates the
kmemleak allocation stack trace in the radix_tree_node_alloc() function.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
---
lib/radix-tree.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/radix-tree.c b/lib/radix-tree.c
index 9599aa72d7a0..5297f8e09096 100644
--- a/lib/radix-tree.c
+++ b/lib/radix-tree.c
@@ -27,6 +27,7 @@
#include <linux/radix-tree.h>
#include <linux/percpu.h>
#include <linux/slab.h>
+#include <linux/kmemleak.h>
#include <linux/notifier.h>
#include <linux/cpu.h>
#include <linux/string.h>
@@ -200,6 +201,11 @@ radix_tree_node_alloc(struct radix_tree_root *root)
rtp->nodes[rtp->nr - 1] = NULL;
rtp->nr--;
}
+ /*
+ * Update the allocation stack trace as this is more useful
+ * for debugging.
+ */
+ kmemleak_update_trace(ret);
}
if (ret == NULL)
ret = kmem_cache_alloc(radix_tree_node_cachep, gfp_mask);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-02 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 13:41 [PATCH 0/6] Kmemleak updates Catalin Marinas
2014-05-02 13:41 ` [PATCH 1/6] mm/kmemleak.c: Use %u to print ->checksum Catalin Marinas
2014-05-02 13:41 ` [PATCH 2/6] mm: Introduce kmemleak_update_trace() Catalin Marinas
2014-05-02 13:41 ` Catalin Marinas [this message]
2014-05-02 13:48 ` [PATCH 3/6] lib: Update the kmemleak stack trace for radix tree allocations Johannes Weiner
2014-05-02 13:41 ` [PATCH 4/6] mm: Update the kmemleak stack trace for mempool allocations Catalin Marinas
2014-05-02 13:41 ` [PATCH 5/6] mm: Call kmemleak directly from memblock_(alloc|free) Catalin Marinas
2014-05-02 13:41 ` [PATCH 6/6] mm: Postpone the disabling of kmemleak early logging Catalin Marinas
2014-05-06 15:20 ` Sasha Levin
2014-05-06 17:05 ` Catalin Marinas
2014-05-06 18:15 ` Sasha Levin
2014-05-06 21:52 ` Catalin Marinas
2014-05-06 23:08 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399038070-1540-4-git-send-email-catalin.marinas@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).