linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <js1304@gmail.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block()
Date: Wed,  7 May 2014 15:06:13 +0900	[thread overview]
Message-ID: <1399442780-28748-4-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1399442780-28748-1-git-send-email-iamjoonsoo.kim@lge.com>

node isn't changed, so we don't need to retreive this structure
everytime we move the object. Maybe compiler do this optimization,
but making it explicitly is better.

Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

diff --git a/mm/slab.c b/mm/slab.c
index e2c80df..92d08e3 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3340,7 +3340,7 @@ static void free_block(struct kmem_cache *cachep, void **objpp, int nr_objects,
 		       int node)
 {
 	int i;
-	struct kmem_cache_node *n;
+	struct kmem_cache_node *n = cachep->node[node];
 
 	for (i = 0; i < nr_objects; i++) {
 		void *objp;
@@ -3349,7 +3349,6 @@ static void free_block(struct kmem_cache *cachep, void **objpp, int nr_objects,
 		objp = clear_obj_pfmemalloc(objpp[i]);
 
 		page = virt_to_head_page(objp);
-		n = cachep->node[node];
 		list_del(&page->lru);
 		check_spinlock_acquired_node(cachep, node);
 		slab_put_obj(cachep, page, objp, node);
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-05-07  6:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  6:06 [PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-05-07  6:06 ` [PATCH v2 01/10] slab: add unlikely macro to help compiler Joonsoo Kim
2014-05-07 14:21   ` Christoph Lameter
2014-05-07  6:06 ` [PATCH v2 02/10] slab: makes clear_obj_pfmemalloc() just return masked value Joonsoo Kim
2014-05-07 14:22   ` Christoph Lameter
2014-05-07  6:06 ` Joonsoo Kim [this message]
2014-05-08  0:52   ` [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() David Rientjes
2014-05-07  6:06 ` [PATCH v2 04/10] slab: defer slab_destroy " Joonsoo Kim
2014-05-08  1:01   ` David Rientjes
2014-05-07  6:06 ` [PATCH v2 05/10] slab: factor out initialization of arracy cache Joonsoo Kim
2014-05-08  1:19   ` David Rientjes
2014-05-07  6:06 ` [PATCH v2 06/10] slab: introduce alien_cache Joonsoo Kim
2014-05-07  6:06 ` [PATCH v2 07/10] slab: use the lock on alien_cache, instead of the lock on array_cache Joonsoo Kim
2014-05-07  6:06 ` [PATCH v2 08/10] slab: destroy a slab without holding any alien cache lock Joonsoo Kim
2014-05-07  6:06 ` [PATCH v2 09/10] slab: remove a useless lockdep annotation Joonsoo Kim
2014-05-07 14:25   ` Christoph Lameter
2014-05-07  6:06 ` [PATCH v2 10/10] slab: remove BAD_ALIEN_MAGIC Joonsoo Kim
2014-05-07 14:24   ` Christoph Lameter
2014-05-21  7:43 ` [PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
  -- strict thread matches above, loose matches on Subject: below --
2014-05-07 21:22 [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() George Spelvin
2014-05-07 21:30 ` David Rientjes
2014-05-07 21:50   ` George Spelvin
2014-05-07 22:05     ` David Rientjes
2014-05-08  0:44       ` George Spelvin
2014-05-08  1:46       ` George Spelvin
2014-05-08 13:51   ` Christoph Lameter
2014-05-08 19:24     ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399442780-28748-4-git-send-email-iamjoonsoo.kim@lge.com \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).