From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4B9C5AE59 for ; Tue, 27 May 2025 02:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB9ED6B007B; Mon, 26 May 2025 22:36:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A206B0083; Mon, 26 May 2025 22:36:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D821D6B0085; Mon, 26 May 2025 22:36:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B7E626B007B for ; Mon, 26 May 2025 22:36:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B348C5FAB8 for ; Tue, 27 May 2025 02:36:48 +0000 (UTC) X-FDA: 83487124896.18.4A80608 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf08.hostedemail.com (Postfix) with ESMTP id C5245160004 for ; Tue, 27 May 2025 02:36:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=g3+iax4G; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748313407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jxLDvATeq4EvUrtiMA5gJipkjRHQ2+Vkf/2GOjiK+w8=; b=u2oOZYXNyx+hs3RUSpnYk3itFSLWZYKEpyYRtAoTnYu22Emf2HgKgyk5e0w+vw7Q/U5rXN fBeVsm04zeaeOeEPj3RY0BcuE2MYBahuD8tyGG3wPLTWJmqokAYaYZ74zYPf3tbR1v9ljw h1jMrKcJJ796ZjRoNdVURp8wMb/yt1Q= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=g3+iax4G; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748313407; a=rsa-sha256; cv=none; b=t7hrx3NGQouMGXKVx5EKkCvzH8h0wI5iyKcS9bDvQ1u4bIpXoTOYTE5i44qrgTB3/j1qsy Zrn41XGXkM8Dtrk425VsoKqZ376awRgawGuiQ5ItKD94J5hotY9ZvTB/8i7UIcF8D89KKv qEvhi4KgYhxFTmdj2eRtU3JjAdfGbIo= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748313404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxLDvATeq4EvUrtiMA5gJipkjRHQ2+Vkf/2GOjiK+w8=; b=g3+iax4GFRzXd63kTruSkLYsAvk2juzEF8GUYMFhDdUfNhHnVBgeAdL9qqpBgBnJdMAcKn Gy2JJ6G3f5k+DxhqMZUTtY+ACvaxRsSTylkgWOrsN8E/KoArwnJoiQ+tI9I+2loo9EidiG NJxjA4425gen6W3nse8X4ltOdYAhxL0= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH] mm, list_lru: refactor the locking code X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20250526180638.14609-1-ryncsn@gmail.com> Date: Tue, 27 May 2025 10:36:02 +0800 Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , Chengming Zhou , Qi Zheng , linux-kernel@vger.kernel.org, kernel test robot , Julia Lawall Content-Transfer-Encoding: 7bit Message-Id: <13AF220A-3792-491A-B5C2-36044C450402@linux.dev> References: <20250526180638.14609-1-ryncsn@gmail.com> To: Kairui Song X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C5245160004 X-Stat-Signature: bdypo5wd3uxdn69d3xsg7anpjomhf3qf X-Rspam-User: X-HE-Tag: 1748313406-528190 X-HE-Meta: U2FsdGVkX196dr0/ygU7Dqidi53O0oIYDup9C0QCjQR+RfzniUOMgMZa8n9XAmnaVXfxLXDrHJ7kkwo5jW5j3mElXX4cUnq44CnqGOgR5HFAUDLWXwWvWIMlZnAWjRIFoJEgaONcEevzgl/B4GXLnonUbzThvHEgvYKsgX6iJtYZdaz3XPL3UGCOiwiYYsKt8tO8DwirhtHlD73uilzWX3iHZTShxz2fReNTRH+6GsfKaloJAUkfHAYw+u5HrWndKtuhPCvnC8T4fvHmAljaWkhSwx2r1oXevCO7lSrBT2NlKp4eI/s2PlxWtw2jzeUuarq0v6tcHojrKRjpaQEXxDMF6TPQblU8m2QJORjThUNJ5fq4U/jxHmeDxp/MW8Pzy5UVe/fV8f2uUJB9Y9CYOqb99+t2kUweFiTqNnuyaUy2ZpHXR08DR8YJLXZDmSvKPA/2uy+fQFOSe5kbCFspENBzpEKoZg1w28cJYt1XuiwUkRP4O9HT8yXD/Zagfsha/rQXGLpgVuUTpp5gm/HqT2c+QsmDTrq2EG5lb7vYyYpRSgr00lFLtKR3D2sGUk1rupdRrLhwslAgpKSYpCt2o7gMppht3jXToRVbn7J/9Dav1Cg4DZeh+rxPAXXzblMc63eaGshVx09x5r9lVEDgrFb2pUbaWXBDLCASqyVaAXnHOuYDRML6eFXC4bYHFet7QFRdNNShSDqEo6eOqKPj9Fl+DBrvkOiKjjNP7Jhac8434q/MrIQq46JzMmrqINR5ZnbiuQVMtoP5l9l85kV6Wt6uAqFDEnI031dYrrb8cYhl1umH9/UnNB5kNnWFxHBmHtQdKasET+eAYIeXz7BPSh6hN1TMUWXJE52DXw9o1ScjJ/TWTLIfa5NpBeQDIxa/EkEd5s8IoEY1KEMtPi3gd3GPchquNdCRCykmJEvv1v2dmZ9SjmghIvm9gCRfa+GLjSBgQe0i7EzPu93r3ly qRVgiG2t kjkBXrVD87knaSdGgKk2XrtDfv6uksX7f8kDr8J/3ZYIGF8Zllewm6yJLQwEeMPPaf7d+8GTqJCBcnN0rOeLId021g/SDySqyJv3P10nmJkHoLhjD4v3yXlxrXJYRFiDl/uK6NVjVxWLPBs+Dx9xCNUN+vtA/3wgmWA7bX6sKVlgDzYfgnOf/D7KyC5B46T7MHGXgDHyQokEloT3MNFXEmG/bMJ5gqRp2A0OK5sZibxWbKXtEaEf8Ryvup8ioV0z2304pJnYeI+m8W06IeIMAXQJgX9QzNn6VZHmNEB1wRYrFEhS3ah1XuWbzBC6yTMzaor0+l00OrAX++4C0SBGUZTjnTbFrCoCRSO4m61RBJTVefUZBeCRoJyz/P5ljbchLFpL9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 27, 2025, at 02:06, Kairui Song wrote: > > From: Kairui Song > > Cocci is confused by the try lock then release RCU and return logic > here. So separate the try lock part out into a standalone helper. The > code is easier to follow too. > > No feature change, fixes: > > cocci warnings: (new ones prefixed by >>) >>> mm/list_lru.c:82:3-9: preceding lock on line 77 >>> mm/list_lru.c:82:3-9: preceding lock on line 77 > mm/list_lru.c:82:3-9: preceding lock on line 75 > mm/list_lru.c:82:3-9: preceding lock on line 75 > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202505252043.pbT1tBHJ-lkp@intel.com/ > Signed-off-by: Kairui Song Reviewed-by: Muchun Song Thanks.