linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Vladimir Davydov <vdavydov@parallels.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v3 1/9] slab: add unlikely macro to help compiler
Date: Tue,  1 Jul 2014 17:27:30 +0900	[thread overview]
Message-ID: <1404203258-8923-2-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1404203258-8923-1-git-send-email-iamjoonsoo.kim@lge.com>

slab_should_failslab() is called on every allocation, so to optimize it
is reasonable. We normally don't allocate from kmem_cache. It is just
used when new kmem_cache is created, so it's very rare case. Therefore,
add unlikely macro to help compiler optimization.

Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/slab.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slab.c b/mm/slab.c
index 179272f..f8a0ed1 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3067,7 +3067,7 @@ static void *cache_alloc_debugcheck_after(struct kmem_cache *cachep,
 
 static bool slab_should_failslab(struct kmem_cache *cachep, gfp_t flags)
 {
-	if (cachep == kmem_cache)
+	if (unlikely(cachep == kmem_cache))
 		return false;
 
 	return should_failslab(cachep->object_size, flags, cachep->flags);
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-07-01  8:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  8:27 [PATCH v3 0/9] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-07-01  8:27 ` Joonsoo Kim [this message]
2014-07-01  8:27 ` [PATCH v3 2/9] slab: move up code to get kmem_cache_node in free_block() Joonsoo Kim
2014-07-01 22:21   ` David Rientjes
2014-07-02  0:39     ` Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 3/9] slab: defer slab_destroy " Joonsoo Kim
2014-07-01 22:25   ` David Rientjes
2014-07-02  0:44     ` Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 4/9] slab: factor out initialization of arracy cache Joonsoo Kim
2014-07-01 22:26   ` David Rientjes
2014-07-02  0:46     ` Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 5/9] slab: introduce alien_cache Joonsoo Kim
2014-07-01 22:15   ` Andrew Morton
2014-07-02  0:48     ` Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 6/9] slab: use the lock on alien_cache, instead of the lock on array_cache Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 7/9] slab: destroy a slab without holding any alien cache lock Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 8/9] slab: remove a useless lockdep annotation Joonsoo Kim
2014-07-01  8:27 ` [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404203258-8923-2-git-send-email-iamjoonsoo.kim@lge.com \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).