From: Jiang Liu <jiang.liu@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Alex Duyck <alexander.h.duyck@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>,
Linux NICS <linux.nics@intel.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, linux-hotplug@vger.kernel.org,
linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node
Date: Fri, 11 Jul 2014 15:37:32 +0800 [thread overview]
Message-ID: <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com>
When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id()
may return a node without memory, and later cause system failure/panic
when calling kmalloc_node() and friends with returned node id.
So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with
memory for the/current cpu.
If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id()
is the same as cpu_to_node()/numa_node_id().
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index f145adbb55ac..2b74bffa5648 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -6518,7 +6518,7 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer,
unsigned int truesize)
{
/* avoid re-using remote pages */
- if (unlikely(page_to_nid(page) != numa_node_id()))
+ if (unlikely(page_to_nid(page) != numa_mem_id()))
return false;
#if (PAGE_SIZE < 8192)
@@ -6588,7 +6588,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring,
memcpy(__skb_put(skb, size), va, ALIGN(size, sizeof(long)));
/* we can reuse buffer as-is, just make sure it is local */
- if (likely(page_to_nid(page) == numa_node_id()))
+ if (likely(page_to_nid(page) == numa_mem_id()))
return true;
/* this page cannot be reused so discard it */
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-11 7:36 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 7:37 [RFC Patch V1 00/30] Enable memoryless node on x86 platforms Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 01/30] mm, kernel: Use cpu_to_mem()/numa_mem_id() to support memoryless node Jiang Liu
2014-07-11 15:14 ` Paul E. McKenney
2014-07-21 17:15 ` Nishanth Aravamudan
2014-07-21 17:33 ` Paul E. McKenney
2014-07-12 12:32 ` Jens Axboe
2014-07-11 7:37 ` [RFC Patch V1 02/30] mm, sched: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 03/30] mm, net: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 04/30] mm, netfilter: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 05/30] mm, perf: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 06/30] mm, tracing: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 07/30] mm: " Jiang Liu
2014-07-11 13:51 ` Christoph Lameter
2014-07-11 14:42 ` Tejun Heo
2014-07-11 15:13 ` Christoph Lameter
2014-07-11 15:21 ` Tejun Heo
2014-07-11 15:33 ` Tejun Heo
2014-07-11 15:55 ` Christoph Lameter
2014-07-11 15:58 ` Tejun Heo
2014-07-11 16:04 ` Christoph Lameter
2014-07-11 15:58 ` Christoph Lameter
2014-07-11 16:01 ` Tejun Heo
2014-07-11 16:19 ` Christoph Lameter
2014-07-11 16:24 ` Tejun Heo
2014-07-11 17:29 ` Christoph Lameter
2014-07-11 18:28 ` Tejun Heo
2014-07-11 19:11 ` Christoph Lameter
2014-07-23 3:16 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 08/30] mm, thp: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 09/30] mm, memcg: " Jiang Liu
2014-07-18 7:36 ` Michal Hocko
2014-07-23 3:18 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 10/30] mm, xfrm: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 11/30] mm, char/mspec.c: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 12/30] mm, IB/qib: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 13/30] mm, i40e: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 14/30] mm, i40evf: " Jiang Liu
2014-07-11 7:37 ` Jiang Liu [this message]
2014-07-21 17:42 ` [RFC Patch V1 15/30] mm, igb: " Nishanth Aravamudan
2014-07-21 19:53 ` Alexander Duyck
2014-07-21 21:09 ` Nishanth Aravamudan
2014-07-23 3:20 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 16/30] mm, ixgbe: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 17/30] mm, intel_powerclamp: " Jiang Liu
2014-07-21 17:38 ` Nishanth Aravamudan
2014-07-11 7:37 ` [RFC Patch V1 18/30] mm, bnx2fc: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 19/30] mm, bnx2i: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 20/30] mm, fcoe: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 21/30] mm, irqchip: " Jiang Liu
2014-07-18 12:40 ` Jason Cooper
2014-07-23 3:47 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 22/30] mm, of: " Jiang Liu
2014-07-21 17:52 ` Nishanth Aravamudan
2014-07-28 13:30 ` Grant Likely
2014-07-28 19:26 ` Nishanth Aravamudan
2014-07-11 7:37 ` [RFC Patch V1 23/30] mm, x86: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 24/30] mm, x86/platform/uv: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 25/30] mm, x86, kvm: " Jiang Liu
2014-07-11 7:44 ` Paolo Bonzini
2014-07-11 7:37 ` [RFC Patch V1 26/30] mm, x86, perf: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 27/30] x86, numa: Kill useless code to improve code readability Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 28/30] mm: Update _mem_id_[] for every possible CPU when memory configuration changes Jiang Liu
2014-07-21 17:47 ` Nishanth Aravamudan
2014-07-23 8:16 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 29/30] mm, x86: Enable memoryless node support to better support CPU/memory hotplug Jiang Liu
2014-07-24 23:26 ` Nishanth Aravamudan
2014-07-25 1:41 ` Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 30/30] x86, NUMA: Online node earlier when doing CPU hot-addition Jiang Liu
2014-07-24 23:30 ` Nishanth Aravamudan
2014-07-25 1:43 ` Jiang Liu
2014-07-25 1:44 ` Jiang Liu
2014-07-11 8:29 ` [RFC Patch V1 00/30] Enable memoryless node on x86 platforms Peter Zijlstra
2014-07-11 15:33 ` Greg KH
2014-07-11 20:02 ` Dave Hansen
2014-07-11 20:20 ` Andi Kleen
2014-07-11 20:51 ` Peter Zijlstra
2014-07-11 21:58 ` Andi Kleen
2014-07-15 1:18 ` David Rientjes
2014-07-11 23:51 ` H. Peter Anvin
2014-07-11 22:40 ` Jiri Kosina
2014-07-15 1:19 ` David Rientjes
2014-07-18 17:48 ` Nish Aravamudan
2014-07-21 17:23 ` Nishanth Aravamudan
2014-07-21 17:41 ` Tony Luck
2014-07-21 17:57 ` Nishanth Aravamudan
2014-07-23 8:20 ` Jiang Liu
2014-07-24 23:32 ` Nishanth Aravamudan
2014-07-25 1:50 ` Jiang Liu
2014-08-18 23:30 ` Nishanth Aravamudan
2014-07-21 20:06 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.nics@intel.com \
--cc=mgorman@suse.de \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rientjes@google.com \
--cc=tony.luck@intel.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).