* [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache
@ 2014-07-16 1:48 Wang Sheng-Hui
2014-07-16 19:30 ` Hugh Dickins
0 siblings, 1 reply; 4+ messages in thread
From: Wang Sheng-Hui @ 2014-07-16 1:48 UTC (permalink / raw)
To: hughd; +Cc: linux-mm
The gfp arg is not used in shmem_add_to_page_cache.
Remove this unused arg.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
mm/shmem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 1140f49..63cc6af 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -280,7 +280,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
*/
static int shmem_add_to_page_cache(struct page *page,
struct address_space *mapping,
- pgoff_t index, gfp_t gfp, void *expected)
+ pgoff_t index, void *expected)
{
int error;
@@ -643,7 +643,7 @@ static int shmem_unuse_inode(struct shmem_inode_info *info,
*/
if (!error)
error = shmem_add_to_page_cache(*pagep, mapping, index,
- GFP_NOWAIT, radswap);
+ radswap);
if (error != -ENOMEM) {
/*
* Truncation and eviction use free_swap_and_cache(), which
@@ -1089,7 +1089,7 @@ repeat:
gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, swp_to_radix_entry(swap));
+ swp_to_radix_entry(swap));
/*
* We already confirmed swap under page lock, and make
* no memory allocation here, so usually no possibility
@@ -1152,7 +1152,7 @@ repeat:
error = radix_tree_maybe_preload(gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, NULL);
+ NULL);
radix_tree_preload_end();
}
if (error) {
--
1.8.3.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache
2014-07-16 1:48 [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache Wang Sheng-Hui
@ 2014-07-16 19:30 ` Hugh Dickins
0 siblings, 0 replies; 4+ messages in thread
From: Hugh Dickins @ 2014-07-16 19:30 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: Andrew Morton, linux-mm
From: Wang Sheng-Hui <shhuiw@gmail.com>
The gfp arg is not used in shmem_add_to_page_cache.
Remove this unused arg.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Yes, this version was fine: thank you.
Andrew, please add to mmotm (no hurry) - thank you.
mm/shmem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 1140f49..63cc6af 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -280,7 +280,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
*/
static int shmem_add_to_page_cache(struct page *page,
struct address_space *mapping,
- pgoff_t index, gfp_t gfp, void *expected)
+ pgoff_t index, void *expected)
{
int error;
@@ -643,7 +643,7 @@ static int shmem_unuse_inode(struct shmem_inode_info *info,
*/
if (!error)
error = shmem_add_to_page_cache(*pagep, mapping, index,
- GFP_NOWAIT, radswap);
+ radswap);
if (error != -ENOMEM) {
/*
* Truncation and eviction use free_swap_and_cache(), which
@@ -1089,7 +1089,7 @@ repeat:
gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, swp_to_radix_entry(swap));
+ swp_to_radix_entry(swap));
/*
* We already confirmed swap under page lock, and make
* no memory allocation here, so usually no possibility
@@ -1152,7 +1152,7 @@ repeat:
error = radix_tree_maybe_preload(gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, NULL);
+ NULL);
radix_tree_preload_end();
}
if (error) {
--
1.8.3.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache
@ 2014-07-14 23:50 Wang Sheng-Hui
2014-07-15 4:03 ` Hugh Dickins
0 siblings, 1 reply; 4+ messages in thread
From: Wang Sheng-Hui @ 2014-07-14 23:50 UTC (permalink / raw)
To: Hugh Dickins, linux-mm
The gfp arg is not used in shmem_add_to_page_cache.
Remove this unused arg.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
mm/shmem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 1140f49..63cc6af 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -280,7 +280,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
*/
static int shmem_add_to_page_cache(struct page *page,
struct address_space *mapping,
- pgoff_t index, gfp_t gfp, void *expected)
+ pgoff_t index, void *expected)
{
int error;
@@ -643,7 +643,7 @@ static int shmem_unuse_inode(struct shmem_inode_info *info,
*/
if (!error)
error = shmem_add_to_page_cache(*pagep, mapping, index,
- GFP_NOWAIT, radswap);
+ radswap);
if (error != -ENOMEM) {
/*
* Truncation and eviction use free_swap_and_cache(), which
@@ -1089,7 +1089,7 @@ repeat:
gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, swp_to_radix_entry(swap));
+ swp_to_radix_entry(swap));
/*
* We already confirmed swap under page lock, and make
* no memory allocation here, so usually no possibility
@@ -1152,7 +1152,7 @@ repeat:
error = radix_tree_maybe_preload(gfp & GFP_RECLAIM_MASK);
if (!error) {
error = shmem_add_to_page_cache(page, mapping, index,
- gfp, NULL);
+ NULL);
radix_tree_preload_end();
}
if (error) {
--
1.8.3.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache
2014-07-14 23:50 Wang Sheng-Hui
@ 2014-07-15 4:03 ` Hugh Dickins
0 siblings, 0 replies; 4+ messages in thread
From: Hugh Dickins @ 2014-07-15 4:03 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: linux-mm
On Tue, 15 Jul 2014, Wang Sheng-Hui wrote:
>
> The gfp arg is not used in shmem_add_to_page_cache.
> Remove this unused arg.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Looks right, but checkpatch.pl has some complaints about the spaces:
please fix those. Maybe you started off with tabs, and gmail turned
them into spaces. gmail is an outstandingly excellent mailer (;)
but unhelpful on patches. See Documentation/email-clients.txt or
Documentation/zh_CN/email-clients.txt. Maybe "git send-email" will
get around it for you.
Thanks,
Hugh
> ---
> mm/shmem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 1140f49..63cc6af 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -280,7 +280,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
> */
> static int shmem_add_to_page_cache(struct page *page,
> struct address_space *mapping,
> - pgoff_t index, gfp_t gfp, void *expected)
> + pgoff_t index, void *expected)
> {
> int error;
>
> @@ -643,7 +643,7 @@ static int shmem_unuse_inode(struct shmem_inode_info *info,
> */
> if (!error)
> error = shmem_add_to_page_cache(*pagep, mapping, index,
> - GFP_NOWAIT, radswap);
> + radswap);
> if (error != -ENOMEM) {
> /*
> * Truncation and eviction use free_swap_and_cache(), which
> @@ -1089,7 +1089,7 @@ repeat:
> gfp & GFP_RECLAIM_MASK);
> if (!error) {
> error = shmem_add_to_page_cache(page, mapping, index,
> - gfp, swp_to_radix_entry(swap));
> + swp_to_radix_entry(swap));
> /*
> * We already confirmed swap under page lock, and make
> * no memory allocation here, so usually no possibility
> @@ -1152,7 +1152,7 @@ repeat:
> error = radix_tree_maybe_preload(gfp & GFP_RECLAIM_MASK);
> if (!error) {
> error = shmem_add_to_page_cache(page, mapping, index,
> - gfp, NULL);
> + NULL);
> radix_tree_preload_end();
> }
> if (error) {
> --
> 1.8.3.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-16 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-16 1:48 [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache Wang Sheng-Hui
2014-07-16 19:30 ` Hugh Dickins
-- strict thread matches above, loose matches on Subject: below --
2014-07-14 23:50 Wang Sheng-Hui
2014-07-15 4:03 ` Hugh Dickins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).