From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B19C606A325 for ; Wed, 18 Nov 2026 18:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YU5tz0Cj Received: by kanga.kvack.org (Postfix) id 919A86B00EF; Wed, 18 Nov 2026 13:01:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CA806B05B0; Wed, 18 Nov 2026 13:01:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 791E36B05B3; Wed, 18 Nov 2026 13:01:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53AF06B00EF for ; Wed, 18 Nov 2026 13:01:45 -0500 (EST) Received: from smtpin02.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E1E6D12083F for ; Wed, 18 Nov 2026 18:01:44 +0000 (UTC) X-FDA: 85449007728.02.671C50F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id 11ED31C000D for ; Wed, 18 Nov 2026 18:01:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YU5tz0Cj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1795024903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dOq8EsFEjMFnCQhxDJFGpo1p31eiea56FSZ835svf0s=; b=56QWDcpr/yN7eQ6flF/JYJj/Ry0e/E2ZXrTugsV+ds9u1ZSQodRJD1n90QegpJdAUajVFz 6f6hoigJXlY1jziSwD7Iifi849whn2iurlx5sHja2QrTtBOVm0GuaJOfHonaHCyi33oiVQ 2VZJC7bNuwgCA5qzsZ36YQN30ryfqro= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YU5tz0Cj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1795024903; b=1lKGFF2Ir86ggWQIygvOywKi9vgEh6ccmrG7CgNQ+/tBYaOeyKZhvvucutBsf0eyvHYRYt yU+H3X/cxpR+8+3boU8RmYxWbr/f5sfT8dGHG742QUN95Wr77b5rk+7muNG2NpPZX4hU4Q k3Fly8JAgfO1Z95SFh8tLoI4XI/z180= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 30ACE458F6; Wed, 18 Nov 2026 18:01:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5A581F000C4; Wed, 18 Nov 2026 18:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795024902; bh=dOq8EsFEjMFnCQhxDJFGpo1p31eiea56FSZ835svf0s=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=YU5tz0CjX0mT7RIW3ioySqL0E4JKgTUvuY1Revky2r1PpPsr3xQiQDChsPuwwVf78 St1MmWOZ8T9W5Kp5EK6xNQnLjeGWNNFBomqSMr4lE37OG7ZZ/kmMzmP0tH/BuybXzx F8BeQfhEhpNw/Ob6aN34eOK2XrzKPyy3h+ZoWphiC0fCK0d1cIyCy1UnhLHiA6XLUi EwGScF4pFnnEDpQ33DVHTlFZKTcdDU3l8FTBzKwk2bsXGSHi39mooFto26G5quoWz4 X96L+++WTq3fP81xgB+rzb2o6STc2qhDgn1M9hrvHlIFqiXwRaz71WLY6Gyq72N2hV CsoVyb+dQzO8w== Message-ID: <140d09e9-e3b2-4f1b-bd46-4ae9f6dacdd4@kernel.org> Date: Wed, 18 Nov 2026 19:01:35 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] mm: gup: move gup_must_unshare() and INTERNAL_GUP_FLAGS to gup.c To: Rik van Riel , Yeoreum Yun , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Jason Gunthorpe , John Hubbard , Peter Xu , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Yuan-Hao Hsu References: <20261110-refactor_gup_fast-v4-0-e779a7674274@arm.com> <20261110-refactor_gup_fast-v4-3-e779a7674274@arm.com> <5f26a5a1e72fc999823bfac94f33b3c06465e519.camel@surriel.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <5f26a5a1e72fc999823bfac94f33b3c06465e519.camel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 11ED31C000D X-Stat-Signature: 3kr846rsh47gy8r3z8nr5c6qq49pdgi7 X-Rspamd-Server: rspam01 X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Rspam-User: X-HE-Tag: 1795024902-337187 X-HE-Meta: U2FsdGVkX19fwRQbFbBuWLCKUj0YGJBzexbA3c0WDNs+Ctnyx4+T5ymvE93TFNchxbbcBC9W1yhBreYhQ583j2z43wMmnCGgM4ppGUduY/5sKQLua1HvHxXmvw3o2yJ1nTugUHDYlikIZ1v/MSOLTDXLi0nkKo3y0AKFljcc6eAom2whm143/gTwqX+bgn1gaP7B0Zgx9yM9+vmVDb2ThlmLCthQi8QJC9V3NOlCowsnQq2VDJgqkMAoZ6gZ8kZsn938Ga/pAwPHBjZyEFD5QqhZ0nrWDGTpxFn1WTIQQZrYn7IYYNtBvGfySGX8bEfNwLdPxmtu7qYxQcXJu0vufgyyIgROZ8KKo6LRQ0ljdF5N9lvWdhJye6jtcId2hq1gvLSn9CxpLvschNHXmv1s+jZrt8u9bbSJu4yG1XsLR3HJ69P6OVLF9rQ0UjLvMhZhTnppnGEjvzgMlbWk/zfFIlQeMtpHGSEGhLiT1GX5ntI7r/INCHlz3EqwxBZup0dd2nF0BDOqsU6cQSxMJID8SK4GceE+dxC7WtQlM6gCFwy71POBhx9z2usLNGhgW/rpfJ3x3wFzVcGqcCZEPoMH9nWT0CKMaWXkHjE/FBj7ISA0xSpHr8NElbHlVftG5U2NN6Rn8t1FoytCzqGXfLzNti969Y1gH8gDoG8rKc6JgnfLg6W1Sxv5em8VngdE4zlyOgK/7kz0h7gToyZcEgTga86W1VZMt66B96I1DYhKOk1Dhe6J2GfKmDZEiwdfnpZWmrPi2tOKhGPcRKoyG9phXMHQMUB6k2jS2DNy/eQ3Bo85r/lv0z7tOQUnlBWjoe+t5I+LBdqL41PpiWA40UOHdEzSOFZIXl7lChjhzlzM5NUQYfudvh2DBSnzPHPdiAgKhib456ND1JROOVqrYPGkabWdx1HdJoyG84t7B2M/048VPWQU8vHAVq57xSBXHBLuiJCiA2usgULklsCynTi 2FOgfhx2 h7eYfbrZHkg8lb/rhKPeZkb2HS1/HVnvEgK4+S24Vx6c2aAlSEAMefCUMmIYl+O4YNmeLFDOGmd8rnzcNZ7zJlDTIm4Y8mRgE975DiGL+fcFerjkNtlAP7yf8v3h3ATiMrf3qIuUgDVwqvJfPQrveAPAa1lwW3xVB6iovT3dSGS4YGmI0sQ5KlqSAlmUIiPeRWQXdAnYWY55McsHLZPZ8S0kJzQcpNWCZxLjMp1W9O+85SKsb5pJA+G0HXhbanrBmg5cDMrJQyTmGQyqc/ulRJUvnhAo57vy1dj1AQklmJCbMkB3u6yG7Kn13JZQWgqx/Yn9VsdCgG7xGdhXhnHrmGMKxyP0UxS/qY0VUlb6EMDw9GrE= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/18/26 17:59, Rik van Riel wrote: > On Tue, 2026-11-10 at 22:52 +0000, Yeoreum Yun wrote: >> >> +static inline bool gup_must_unshare(struct vm_area_struct *vma, >> +     unsigned int flags, struct page >> *page) >> +{ >> + /* >> + * FOLL_WRITE is implicitly handled correctly as the page >> table entry >> + * has to be writable -- and if it references (part of) an >> anonymous >> + * folio, that part is required to be marked exclusive. >> + */ >> + if ((flags & (FOLL_WRITE | FOLL_PIN)) != FOLL_PIN) >> + return false; > > While I was playing around with some AI loop to > automatically improve review-prompts, one of the > AI engines (out of 6 different ones) spotted a > bug with this code, as used in this series. > Preexisting one? The please send the fix separate. > I have a reproducer to verify it, and will send > in the fix with v6 of my GUP series later this > week. If the fix is for this series, also send it here so we can squash it. -- Cheers, David