linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: build error in dump_mm without CONFIG_COMPACTION
@ 2014-09-23  2:54 Sasha Levin
  2014-09-23 22:15 ` David Rientjes
  0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2014-09-23  2:54 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel, Sasha Levin

In the case of CONFIG_NUMA_BALANCING set and CONFIG_COMPACTION isn't,
we'd fail to put a "," at the end of the formatting string and cause
a build failure.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 mm/debug.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/debug.c b/mm/debug.c
index 544d8f6..8fbc417 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -192,9 +192,9 @@ void dump_mm(const struct mm_struct *mm)
 		"numa_next_scan %lu numa_scan_offset %lu numa_scan_seq %d\n"
 #endif
 #if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
-		"tlb_flush_pending %d\n",
+		"tlb_flush_pending %d\n"
 #endif
-		mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
+		, mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
 #ifdef CONFIG_MMU
 		mm->get_unmapped_area,
 #endif
-- 
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: build error in dump_mm without CONFIG_COMPACTION
  2014-09-23  2:54 [PATCH] mm: build error in dump_mm without CONFIG_COMPACTION Sasha Levin
@ 2014-09-23 22:15 ` David Rientjes
  0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2014-09-23 22:15 UTC (permalink / raw)
  To: Sasha Levin; +Cc: akpm, linux-mm, linux-kernel

On Mon, 22 Sep 2014, Sasha Levin wrote:

> In the case of CONFIG_NUMA_BALANCING set and CONFIG_COMPACTION isn't,
> we'd fail to put a "," at the end of the formatting string and cause
> a build failure.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Looks like this is being addressed in http://marc.info/?t=141146436200007.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-23 22:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23  2:54 [PATCH] mm: build error in dump_mm without CONFIG_COMPACTION Sasha Levin
2014-09-23 22:15 ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).