* [PATCH] mm: fremap use linux header
@ 2014-10-02 15:34 Paul McQuade
2014-10-02 16:23 ` Rik van Riel
0 siblings, 1 reply; 2+ messages in thread
From: Paul McQuade @ 2014-10-02 15:34 UTC (permalink / raw)
To: paulmcquad
Cc: akpm, hughd, gorcunov, kirill.shutemov, riel, linux-mm,
linux-kernel
Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
mm/fremap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/fremap.c b/mm/fremap.c
index 72b8fa3..d614f1c 100644
--- a/mm/fremap.c
+++ b/mm/fremap.c
@@ -1,6 +1,6 @@
/*
* linux/mm/fremap.c
- *
+ *
* Explicit pagetable population and nonlinear (random) mappings support.
*
* started by Ingo Molnar, Copyright (C) 2002, 2003
@@ -16,8 +16,8 @@
#include <linux/rmap.h>
#include <linux/syscalls.h>
#include <linux/mmu_notifier.h>
+#include <linux/mmu_context.h>
-#include <asm/mmu_context.h>
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: fremap use linux header
2014-10-02 15:34 [PATCH] mm: fremap use linux header Paul McQuade
@ 2014-10-02 16:23 ` Rik van Riel
0 siblings, 0 replies; 2+ messages in thread
From: Rik van Riel @ 2014-10-02 16:23 UTC (permalink / raw)
To: Paul McQuade
Cc: akpm, hughd, gorcunov, kirill.shutemov, linux-mm, linux-kernel
On 10/02/2014 11:34 AM, Paul McQuade wrote:
> Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
linux/mmu_context.h does not include asm/mmu_context.h
This leads me to believe that either fremap.c does not use
any definitions from either mmu_context.h file, or after
your change the code that fremap.c needs is no longer directly
included (but only imported indirectly due to sheer luck).
Could you verify which of these is the case?
If fremap.c is not using any code from mmu_context.h, we are
better off simply removing that line, instead of replacing it
with an unnecessary include...
> diff --git a/mm/fremap.c b/mm/fremap.c
> index 72b8fa3..d614f1c 100644
> --- a/mm/fremap.c
> +++ b/mm/fremap.c
> @@ -1,6 +1,6 @@
> /*
> * linux/mm/fremap.c
> - *
> + *
> * Explicit pagetable population and nonlinear (random) mappings support.
> *
> * started by Ingo Molnar, Copyright (C) 2002, 2003
> @@ -16,8 +16,8 @@
> #include <linux/rmap.h>
> #include <linux/syscalls.h>
> #include <linux/mmu_notifier.h>
> +#include <linux/mmu_context.h>
>
> -#include <asm/mmu_context.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-02 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-02 15:34 [PATCH] mm: fremap use linux header Paul McQuade
2014-10-02 16:23 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).