From: Thierry Reding <thierry.reding@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/cma: Make kmemleak ignore CMA regions
Date: Tue, 21 Oct 2014 14:14:56 +0200 [thread overview]
Message-ID: <1413893696-25484-1-git-send-email-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
kmemleak will add allocations as objects to a pool. The memory allocated
for each object in this pool is periodically searched for pointers to
other allocated objects. This only works for memory that is mapped into
the kernel's virtual address space, which happens not to be the case for
most CMA regions.
Furthermore, CMA regions are typically used to store data transferred to
or from a device and therefore don't contain pointers to other objects.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Note: I'm not sure this is really the right fix. But without this, the
kernel crashes on the first execution of the scan_gray_list() because
it tries to access highmem. Perhaps a more appropriate fix would be to
reject any object that can't map to a kernel virtual address?
---
mm/cma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/cma.c b/mm/cma.c
index 963bc4add9af..349f9266f6d3 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -280,6 +280,7 @@ int __init cma_declare_contiguous(phys_addr_t base,
ret = -ENOMEM;
goto err;
} else {
+ kmemleak_ignore(phys_to_virt(addr));
base = addr;
}
}
--
2.1.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-10-21 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:14 Thierry Reding [this message]
2014-10-23 20:22 ` [PATCH] mm/cma: Make kmemleak ignore CMA regions Andrew Morton
2014-10-23 21:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413893696-25484-1-git-send-email-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).