From: Davidlohr Bueso <dave@stgolabs.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: akpm@linux-foundation.org, hughd@google.com, riel@redhat.com,
mgorman@suse.de, peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 03/10] mm: convert i_mmap_mutex to rwsem
Date: Tue, 28 Oct 2014 13:27:19 -0700 [thread overview]
Message-ID: <1414528039.10092.21.camel@linux-t7sj.site> (raw)
In-Reply-To: <20141024224537.GA21108@node.dhcp.inet.fi>
On Sat, 2014-10-25 at 01:45 +0300, Kirill A. Shutemov wrote:
> On Fri, Oct 24, 2014 at 03:06:13PM -0700, Davidlohr Bueso wrote:
> > diff --git a/mm/fremap.c b/mm/fremap.c
> > index 72b8fa3..11ef7ec 100644
> > --- a/mm/fremap.c
> > +++ b/mm/fremap.c
> > @@ -238,13 +238,13 @@ get_write_lock:
> > }
> > goto out_freed;
> > }
> > - mutex_lock(&mapping->i_mmap_mutex);
> > + i_mmap_lock_write(mapping);
> > flush_dcache_mmap_lock(mapping);
> > vma->vm_flags |= VM_NONLINEAR;
> > vma_interval_tree_remove(vma, &mapping->i_mmap);
> > vma_nonlinear_insert(vma, &mapping->i_mmap_nonlinear);
> > flush_dcache_mmap_unlock(mapping);
> > - mutex_unlock(&mapping->i_mmap_mutex);
> > + i_mmap_unlock_write(mapping);
> > }
> >
> > if (vma->vm_flags & VM_LOCKED) {
>
> This should go to previous patch.
Indeed. I had forgotten I snuck that change in as when I was writing the
patch there was a conflict with that fremap. However you removed
mm/fremap.c altogether in -next (mm: replace remap_file_pages() syscall
with emulation) so I'll just update accordingly.
Thanks,
Davidlohr
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-28 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 22:06 [PATCH 00/10] mm: improve usage of the i_mmap lock Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 01/10] mm,fs: introduce helpers around the i_mmap_mutex Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 02/10] mm: use new helper functions " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 03/10] mm: convert i_mmap_mutex to rwsem Davidlohr Bueso
2014-10-24 22:45 ` Kirill A. Shutemov
2014-10-28 20:27 ` Davidlohr Bueso [this message]
2014-10-24 22:06 ` [PATCH 04/10] mm/rmap: share the i_mmap_rwsem Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 05/10] uprobes: " Davidlohr Bueso
2014-10-27 7:03 ` Srikar Dronamraju
2014-10-28 2:02 ` Oleg Nesterov
2014-10-24 22:06 ` [PATCH 06/10] mm/xip: " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 07/10] mm/memory-failure: " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 08/10] mm/mremap: " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 09/10] mm/nommu: " Davidlohr Bueso
2014-10-24 22:16 ` [PATCH 10/10] mm/hugetlb: " Davidlohr Bueso
2014-10-28 14:08 ` [PATCH 00/10] mm: improve usage of the i_mmap lock Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2014-10-30 19:34 [PATCH v2 -next " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 03/10] mm: convert i_mmap_mutex to rwsem Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414528039.10092.21.camel@linux-t7sj.site \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).