linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: akpm@linux-foundation.org
Cc: hughd@google.com, riel@redhat.com, mgorman@suse.de,
	peterz@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, dbueso@suse.de, linux-mm@kvack.org,
	Davidlohr Bueso <dave@stgolabs.net>,
	Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH 05/10] uprobes: share the i_mmap_rwsem
Date: Thu, 30 Oct 2014 12:34:12 -0700	[thread overview]
Message-ID: <1414697657-1678-6-git-send-email-dave@stgolabs.net> (raw)
In-Reply-To: <1414697657-1678-1-git-send-email-dave@stgolabs.net>

Both register and unregister call build_map_info() in order
to create the list of mappings before installing or removing
breakpoints for every mm which maps file backed memory. As
such, there is no reason to hold the i_mmap_rwsem exclusively,
so share it and allow concurrent readers to build the mapping
data.

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@intel.linux.com>
---
 kernel/events/uprobes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index e1bb60d..6158a64b 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -724,7 +724,7 @@ build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
 	int more = 0;
 
  again:
-	i_mmap_lock_write(mapping);
+	i_mmap_lock_read(mapping);
 	vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff, pgoff) {
 		if (!valid_vma(vma, is_register))
 			continue;
@@ -755,7 +755,7 @@ build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
 		info->mm = vma->vm_mm;
 		info->vaddr = offset_to_vaddr(vma, offset);
 	}
-	i_mmap_unlock_write(mapping);
+	i_mmap_unlock_read(mapping);
 
 	if (!more)
 		goto out;
-- 
1.8.4.5

  parent reply	other threads:[~2014-10-30 19:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 19:34 [PATCH v2 -next 00/10] mm: improve usage of the i_mmap lock Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 01/10] mm,fs: introduce helpers around the i_mmap_mutex Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 02/10] mm: use new helper functions " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 03/10] mm: convert i_mmap_mutex to rwsem Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 04/10] mm/rmap: share the i_mmap_rwsem Davidlohr Bueso
2014-10-30 19:34 ` Davidlohr Bueso [this message]
2014-10-30 19:34 ` [PATCH 06/10] mm/xip: " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 07/10] mm/memory-failure: " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 08/10] mm/mremap: " Davidlohr Bueso
2014-11-04  6:04   ` Hugh Dickins
2014-11-04 12:29     ` Kirill A. Shutemov
2014-10-30 19:34 ` [PATCH 09/10] mm/nommu: " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 10/10] mm/hugetlb: " Davidlohr Bueso
2014-11-04  6:35   ` Hugh Dickins
2014-11-05  0:59     ` Davidlohr Bueso
2014-11-05 16:04       ` Hugh Dickins
2014-11-10 16:22     ` Mel Gorman
2014-11-03  8:17 ` [PATCH v2 -next 00/10] mm: improve usage of the i_mmap lock Peter Zijlstra
2014-11-10 16:28 ` Mel Gorman
  -- strict thread matches above, loose matches on Subject: below --
2014-10-24 22:06 [PATCH " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 05/10] uprobes: share the i_mmap_rwsem Davidlohr Bueso
2014-10-27  7:03   ` Srikar Dronamraju
2014-10-28  2:02     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414697657-1678-6-git-send-email-dave@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=akpm@linux-foundation.org \
    --cc=dbueso@suse.de \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).