* [PATCH 0/2] Fix node meminfo corruption.
@ 2014-10-31 9:46 Tang Chen
0 siblings, 0 replies; 5+ messages in thread
From: Tang Chen @ 2014-10-31 9:46 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, yinghai,
isimatu.yasuaki, fabf, nzimmer, wangnan0, vdavydov, toshi.kani,
phacht, tj, kirill.shutemov, riel, luto, hpa, aarcange, qiuxishi,
mgorman, rientjes, hannes
Cc: linux-mm, linux-kernel
There are two problems when calculating node meminfo:
1. When hot-adding a node without onlining any page, MemTotal corrupted.
# hot-add node2 (memory not onlined)
# cat /sys/device/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB /* corrupted */
Node 2 MemFree: 0 kB
Node 2 MemUsed: 33554432 kB
Node 2 Active: 0 kB
......
2. When onlining memory on node2, MemFree of node3 corrupted.
# for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
# cat /sys/devices/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB
Node 2 MemFree: 33549092 kB
Node 2 MemUsed: 5340 kB
......
# cat /sys/devices/system/node/node3/meminfo
Node 3 MemTotal: 0 kB
Node 3 MemFree: 248 kB /* corrupted */
Node 3 MemUsed: 0 kB
......
This patch-set fixes them.
Tang Chen (2):
mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
mem-hotplug: Fix wrong check for zone->pageset initialization in
online_pages().
include/linux/bootmem.h | 1 +
include/linux/mm.h | 1 +
mm/bootmem.c | 9 +++++----
mm/memory_hotplug.c | 15 ++++++++++++++-
mm/nobootmem.c | 8 +++++---
mm/page_alloc.c | 5 +++++
6 files changed, 31 insertions(+), 8 deletions(-)
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 0/2] Fix node meminfo corruption.
@ 2014-10-31 9:46 Tang Chen
2014-11-04 1:10 ` Tang Chen
0 siblings, 1 reply; 5+ messages in thread
From: Tang Chen @ 2014-10-31 9:46 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, yinghai,
isimatu.yasuaki, fabf, nzimmer, wangnan0, vdavydov, toshi.kani,
phacht, tj, kirill.shutemov, riel, luto, hpa, aarcange, qiuxishi,
mgorman, rientjes, hannes
Cc: linux-mm, linux-kernel, tangchen
There are two problems when calculating node meminfo:
1. When hot-adding a node without onlining any page, MemTotal corrupted.
# hot-add node2 (memory not onlined)
# cat /sys/device/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB /* corrupted */
Node 2 MemFree: 0 kB
Node 2 MemUsed: 33554432 kB
Node 2 Active: 0 kB
......
2. When onlining memory on node2, MemFree of node3 corrupted.
# for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
# cat /sys/devices/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB
Node 2 MemFree: 33549092 kB
Node 2 MemUsed: 5340 kB
......
# cat /sys/devices/system/node/node3/meminfo
Node 3 MemTotal: 0 kB
Node 3 MemFree: 248 kB /* corrupted */
Node 3 MemUsed: 0 kB
......
This patch-set fixes them.
Tang Chen (2):
mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
mem-hotplug: Fix wrong check for zone->pageset initialization in
online_pages().
include/linux/bootmem.h | 1 +
include/linux/mm.h | 1 +
mm/bootmem.c | 9 +++++----
mm/memory_hotplug.c | 15 ++++++++++++++-
mm/nobootmem.c | 8 +++++---
mm/page_alloc.c | 5 +++++
6 files changed, 31 insertions(+), 8 deletions(-)
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 0/2] Fix node meminfo corruption.
2014-10-31 9:46 Tang Chen
@ 2014-11-04 1:10 ` Tang Chen
0 siblings, 0 replies; 5+ messages in thread
From: Tang Chen @ 2014-11-04 1:10 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, yinghai,
isimatu.yasuaki, fabf, nzimmer, wangnan0, vdavydov, toshi.kani,
phacht, tj, kirill.shutemov, riel, luto, hpa, aarcange, qiuxishi,
mgorman, rientjes, hannes
Cc: linux-mm, linux-kernel, tangchen
Hi all,
I thinks these two problems are very important and should be merged ASAP.
Would you please help to have a look at it ?
Thanks.
On 10/31/2014 05:46 PM, Tang Chen wrote:
> There are two problems when calculating node meminfo:
>
> 1. When hot-adding a node without onlining any page, MemTotal corrupted.
>
> # hot-add node2 (memory not onlined)
> # cat /sys/device/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB /* corrupted */
> Node 2 MemFree: 0 kB
> Node 2 MemUsed: 33554432 kB
> Node 2 Active: 0 kB
> ......
>
>
> 2. When onlining memory on node2, MemFree of node3 corrupted.
>
> # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
> # cat /sys/devices/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB
> Node 2 MemFree: 33549092 kB
> Node 2 MemUsed: 5340 kB
> ......
> # cat /sys/devices/system/node/node3/meminfo
> Node 3 MemTotal: 0 kB
> Node 3 MemFree: 248 kB /* corrupted */
> Node 3 MemUsed: 0 kB
> ......
>
> This patch-set fixes them.
>
> Tang Chen (2):
> mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
> mem-hotplug: Fix wrong check for zone->pageset initialization in
> online_pages().
>
> include/linux/bootmem.h | 1 +
> include/linux/mm.h | 1 +
> mm/bootmem.c | 9 +++++----
> mm/memory_hotplug.c | 15 ++++++++++++++-
> mm/nobootmem.c | 8 +++++---
> mm/page_alloc.c | 5 +++++
> 6 files changed, 31 insertions(+), 8 deletions(-)
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/2] Fix node meminfo corruption.
@ 2014-11-12 8:36 Tang Chen
2014-11-12 8:38 ` Tang Chen
0 siblings, 1 reply; 5+ messages in thread
From: Tang Chen @ 2014-11-12 8:36 UTC (permalink / raw)
To: akpm, grygorii.strashko, yinghai, isimatu.yasuaki, fabf, nzimmer,
wangnan0, vdavydov, toshi.kani, phacht, tj, kirill.shutemov, riel,
luto, hpa, aarcange, qiuxishi, mgorman, rientjes, hannes
Cc: linux-mm, linux-kernel, tangchen
There are two problems when calculating node meminfo:
1. When hot-adding a node without onlining any page, MemTotal corrupted.
# hot-add node2 (memory not onlined)
# cat /sys/device/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB /* corrupted */
Node 2 MemFree: 0 kB
Node 2 MemUsed: 33554432 kB
Node 2 Active: 0 kB
......
2. When onlining memory on node2, MemFree of node3 corrupted.
# for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
# cat /sys/devices/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB
Node 2 MemFree: 33549092 kB
Node 2 MemUsed: 5340 kB
......
# cat /sys/devices/system/node/node3/meminfo
Node 3 MemTotal: 0 kB
Node 3 MemFree: 248 kB /* corrupted */
Node 3 MemUsed: 0 kB
......
This patch-set fixes them.
Tang Chen (2):
mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
mem-hotplug: Fix wrong check for zone->pageset initialization in
online_pages().
include/linux/bootmem.h | 1 +
include/linux/mm.h | 1 +
mm/bootmem.c | 9 +++++----
mm/memory_hotplug.c | 15 ++++++++++++++-
mm/nobootmem.c | 8 +++++---
mm/page_alloc.c | 5 +++++
6 files changed, 31 insertions(+), 8 deletions(-)
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 0/2] Fix node meminfo corruption.
2014-11-12 8:36 Tang Chen
@ 2014-11-12 8:38 ` Tang Chen
0 siblings, 0 replies; 5+ messages in thread
From: Tang Chen @ 2014-11-12 8:38 UTC (permalink / raw)
To: akpm, grygorii.strashko, yinghai, isimatu.yasuaki, fabf, nzimmer,
wangnan0, vdavydov, toshi.kani, phacht, tj, kirill.shutemov, riel,
luto, hpa, aarcange, qiuxishi, mgorman, rientjes, hannes
Cc: linux-mm, linux-kernel, tangchen
Sorry, please ignore this series. Sent by mistake.
On 11/12/2014 04:36 PM, Tang Chen wrote:
> There are two problems when calculating node meminfo:
>
> 1. When hot-adding a node without onlining any page, MemTotal corrupted.
>
> # hot-add node2 (memory not onlined)
> # cat /sys/device/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB /* corrupted */
> Node 2 MemFree: 0 kB
> Node 2 MemUsed: 33554432 kB
> Node 2 Active: 0 kB
> ......
>
>
> 2. When onlining memory on node2, MemFree of node3 corrupted.
>
> # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
> # cat /sys/devices/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB
> Node 2 MemFree: 33549092 kB
> Node 2 MemUsed: 5340 kB
> ......
> # cat /sys/devices/system/node/node3/meminfo
> Node 3 MemTotal: 0 kB
> Node 3 MemFree: 248 kB /* corrupted */
> Node 3 MemUsed: 0 kB
> ......
>
> This patch-set fixes them.
>
> Tang Chen (2):
> mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
> mem-hotplug: Fix wrong check for zone->pageset initialization in
> online_pages().
>
> include/linux/bootmem.h | 1 +
> include/linux/mm.h | 1 +
> mm/bootmem.c | 9 +++++----
> mm/memory_hotplug.c | 15 ++++++++++++++-
> mm/nobootmem.c | 8 +++++---
> mm/page_alloc.c | 5 +++++
> 6 files changed, 31 insertions(+), 8 deletions(-)
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-12 8:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 9:46 [PATCH 0/2] Fix node meminfo corruption Tang Chen
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 9:46 Tang Chen
2014-11-04 1:10 ` Tang Chen
2014-11-12 8:36 Tang Chen
2014-11-12 8:38 ` Tang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).