linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Peter Hurley <peter@hurleysoftware.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info
Date: Mon,  3 Nov 2014 17:57:53 +0100	[thread overview]
Message-ID: <1415033873-28569-1-git-send-email-mina86@mina86.com> (raw)
In-Reply-To: <2457604.k03RC2Mv4q@avalon>

Having test_pages_isolated failure message as a warning confuses
users into thinking that it is more serious than it really is.  In
reality, if called via CMA, allocation will be retried so a single
test_pages_isolated failure does not prevent allocation from
succeeding.

Demote the warning message to an info message and reformat it such
that the text “failed” does not appear and instead a less worrying
“PFNS busy” is used.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
 mm/page_alloc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 372e3f3..e2731eb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6431,13 +6431,12 @@ int alloc_contig_range(unsigned long start, unsigned long end,
 
 	/* Make sure the range is really isolated. */
 	if (test_pages_isolated(outer_start, end, false)) {
-		pr_warn("alloc_contig_range test_pages_isolated(%lx, %lx) failed\n",
-		       outer_start, end);
+		pr_info("%s: [%lx, %lx) PFNs busy\n",
+			__func__, outer_start, end);
 		ret = -EBUSY;
 		goto done;
 	}
 
-
 	/* Grab isolated pages from freelists. */
 	outer_end = isolate_freepages_range(&cc, outer_start, end);
 	if (!outer_end) {
-- 
2.1.0.rc2.206.gedb03e5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-11-03 16:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 21:09 CMA: test_pages_isolated failures in alloc_contig_range Laurent Pinchart
2014-10-27 20:38 ` Laura Abbott
2014-10-28 15:12   ` Laurent Pinchart
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 13:48   ` Peter Hurley
2014-10-28 16:57     ` Michal Nazarewicz
2014-11-04  3:38       ` Peter Hurley
2014-10-28 18:59     ` Laurent Pinchart
2014-11-03 16:57 ` Michal Nazarewicz [this message]
2014-11-04  5:43   ` [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info Minchan Kim
2014-11-04 12:22     ` Peter Hurley
2014-11-04 13:35       ` Michal Nazarewicz
2014-11-04 14:19         ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415033873-28569-1-git-send-email-mina86@mina86.com \
    --to=mina86@mina86.com \
    --cc=akpm@linux-foundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).