From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 72F456B00A6 for ; Wed, 5 Nov 2014 09:50:48 -0500 (EST) Received: by mail-pd0-f170.google.com with SMTP id z10so899627pdj.1 for ; Wed, 05 Nov 2014 06:50:48 -0800 (PST) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id au4si3160374pbd.174.2014.11.05.06.50.44 for ; Wed, 05 Nov 2014 06:50:45 -0800 (PST) From: "Kirill A. Shutemov" Subject: [PATCH 08/19] mm: prepare migration code for new THP refcounting Date: Wed, 5 Nov 2014 16:49:43 +0200 Message-Id: <1415198994-15252-9-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1415198994-15252-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1415198994-15252-1-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Andrea Arcangeli Cc: Dave Hansen , Hugh Dickins , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A. Shutemov" With new refcounting VMAs can start or end in the middle of huge page. We need to modify code to call split_huge_page() properly. Signed-off-by: Kirill A. Shutemov --- mm/migrate.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index f1a12ced2531..4dc941100388 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1235,7 +1235,7 @@ static int do_move_page_to_node_array(struct mm_struct *mm, vma = find_vma(mm, pp->addr); if (!vma || pp->addr < vma->vm_start || !vma_migratable(vma)) goto set_status; - +retry: page = follow_page(vma, pp->addr, FOLL_GET); err = PTR_ERR(page); @@ -1246,9 +1246,27 @@ static int do_move_page_to_node_array(struct mm_struct *mm, if (!page) goto set_status; - if (PageTransHuge(page) && split_huge_page(page)) { - err = -EBUSY; - goto set_status; + if (PageTransCompound(page)) { + struct page *head_page = compound_head(page); + + /* + * split_huge_page() wants pin to be only on head page + */ + if (page != head_page) { + get_page(head_page); + put_page(page); + } + + err = split_huge_page(head_page); + if (err) { + put_page(head_page); + goto set_status; + } + + if (page != head_page) { + put_page(head_page); + goto retry; + } } /* Use PageReserved to check for zero page */ -- 2.1.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org