* [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
@ 2014-11-12 14:37 Mahendran Ganesh
2014-11-13 0:02 ` Minchan Kim
2014-11-13 14:55 ` Sergey Senozhatsky
0 siblings, 2 replies; 6+ messages in thread
From: Mahendran Ganesh @ 2014-11-12 14:37 UTC (permalink / raw)
To: ngupta, minchan, weijie.yang, sergey.senozhatsky
Cc: linux-mm, linux-kernel, Mahendran Ganesh
In struct zram_table_entry, the element *value* contains obj size and
obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
instead of (ZRAM_FLAG_SHIFT + 1).
This patch fixes this issue.
Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
---
drivers/block/zram/zram_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
index c6ee271..b05a816 100644
--- a/drivers/block/zram/zram_drv.h
+++ b/drivers/block/zram/zram_drv.h
@@ -66,8 +66,8 @@ static const size_t max_zpage_size = PAGE_SIZE / 4 * 3;
/* Flags for zram pages (table[page_no].value) */
enum zram_pageflags {
/* Page consists entirely of zeros */
- ZRAM_ZERO = ZRAM_FLAG_SHIFT + 1,
- ZRAM_ACCESS, /* page in now accessed */
+ ZRAM_ZERO = ZRAM_FLAG_SHIFT,
+ ZRAM_ACCESS, /* page is now accessed */
__NR_ZRAM_PAGEFLAGS,
};
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
2014-11-12 14:37 [PATCH] mm/zram: correct ZRAM_ZERO flag bit position Mahendran Ganesh
@ 2014-11-13 0:02 ` Minchan Kim
2014-11-13 1:27 ` Weijie Yang
2014-11-13 13:54 ` Ganesh Mahendran
2014-11-13 14:55 ` Sergey Senozhatsky
1 sibling, 2 replies; 6+ messages in thread
From: Minchan Kim @ 2014-11-13 0:02 UTC (permalink / raw)
To: Mahendran Ganesh
Cc: ngupta, weijie.yang, sergey.senozhatsky, linux-mm, linux-kernel
On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
> In struct zram_table_entry, the element *value* contains obj size and
> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
> instead of (ZRAM_FLAG_SHIFT + 1).
>
> This patch fixes this issue.
>
> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
To be clear about "fixes this issue", it's not a bug but just clean up
so it doesn't change any behavior.
Thanks!
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
2014-11-13 0:02 ` Minchan Kim
@ 2014-11-13 1:27 ` Weijie Yang
2014-11-13 13:54 ` Ganesh Mahendran
2014-11-13 13:54 ` Ganesh Mahendran
1 sibling, 1 reply; 6+ messages in thread
From: Weijie Yang @ 2014-11-13 1:27 UTC (permalink / raw)
To: 'Mahendran Ganesh'
Cc: 'Minchan Kim', ngupta, sergey.senozhatsky, linux-mm,
linux-kernel
On Thu, Nov 13, 2014 at 8:02 AM, Minchan Kim <minchan@kernel.org> wrote:
> On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
>> In struct zram_table_entry, the element *value* contains obj size and
>> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
>> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
>> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
>> instead of (ZRAM_FLAG_SHIFT + 1).
>>
>> This patch fixes this issue.
>>
>> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: Weijie Yang <weijie.yang@samsung.com>
> To be clear about "fixes this issue", it's not a bug but just clean up
> so it doesn't change any behavior.
>
> Thanks!
>
> --
> Kind regards,
> Minchan Kim
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
2014-11-13 1:27 ` Weijie Yang
@ 2014-11-13 13:54 ` Ganesh Mahendran
0 siblings, 0 replies; 6+ messages in thread
From: Ganesh Mahendran @ 2014-11-13 13:54 UTC (permalink / raw)
To: Weijie Yang
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, linux-mm,
linux-kernel
2014-11-13 9:27 GMT+08:00 Weijie Yang <weijie.yang@samsung.com>:
> On Thu, Nov 13, 2014 at 8:02 AM, Minchan Kim <minchan@kernel.org> wrote:
>> On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
>>> In struct zram_table_entry, the element *value* contains obj size and
>>> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
>>> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
>>> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
>>> instead of (ZRAM_FLAG_SHIFT + 1).
>>>
>>> This patch fixes this issue.
>>>
>>> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>>>
>>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
>> Acked-by: Minchan Kim <minchan@kernel.org>
>
> Acked-by: Weijie Yang <weijie.yang@samsung.com>
Thanks
>
>> To be clear about "fixes this issue", it's not a bug but just clean up
>> so it doesn't change any behavior.
>>
>> Thanks!
>>
>> --
>> Kind regards,
>> Minchan Kim
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
2014-11-13 0:02 ` Minchan Kim
2014-11-13 1:27 ` Weijie Yang
@ 2014-11-13 13:54 ` Ganesh Mahendran
1 sibling, 0 replies; 6+ messages in thread
From: Ganesh Mahendran @ 2014-11-13 13:54 UTC (permalink / raw)
To: Minchan Kim
Cc: Nitin Gupta, weijie.yang, Sergey Senozhatsky, linux-mm,
linux-kernel
2014-11-13 8:02 GMT+08:00 Minchan Kim <minchan@kernel.org>:
> On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
>> In struct zram_table_entry, the element *value* contains obj size and
>> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
>> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
>> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
>> instead of (ZRAM_FLAG_SHIFT + 1).
>>
>> This patch fixes this issue.
>>
>> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
>
> To be clear about "fixes this issue", it's not a bug but just clean up
> so it doesn't change any behavior.
>
> Thanks!
>
> --
> Kind regards,
> Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
2014-11-12 14:37 [PATCH] mm/zram: correct ZRAM_ZERO flag bit position Mahendran Ganesh
2014-11-13 0:02 ` Minchan Kim
@ 2014-11-13 14:55 ` Sergey Senozhatsky
1 sibling, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2014-11-13 14:55 UTC (permalink / raw)
To: Mahendran Ganesh
Cc: ngupta, minchan, weijie.yang, sergey.senozhatsky, linux-mm,
linux-kernel
On (11/12/14 22:37), Mahendran Ganesh wrote:
> In struct zram_table_entry, the element *value* contains obj size and
> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
> instead of (ZRAM_FLAG_SHIFT + 1).
>
> This patch fixes this issue.
well, I wouldn't say this is an issue; but still.
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> ---
> drivers/block/zram/zram_drv.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> index c6ee271..b05a816 100644
> --- a/drivers/block/zram/zram_drv.h
> +++ b/drivers/block/zram/zram_drv.h
> @@ -66,8 +66,8 @@ static const size_t max_zpage_size = PAGE_SIZE / 4 * 3;
> /* Flags for zram pages (table[page_no].value) */
> enum zram_pageflags {
> /* Page consists entirely of zeros */
> - ZRAM_ZERO = ZRAM_FLAG_SHIFT + 1,
> - ZRAM_ACCESS, /* page in now accessed */
> + ZRAM_ZERO = ZRAM_FLAG_SHIFT,
> + ZRAM_ACCESS, /* page is now accessed */
>
> __NR_ZRAM_PAGEFLAGS,
> };
> --
> 1.7.9.5
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-13 14:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 14:37 [PATCH] mm/zram: correct ZRAM_ZERO flag bit position Mahendran Ganesh
2014-11-13 0:02 ` Minchan Kim
2014-11-13 1:27 ` Weijie Yang
2014-11-13 13:54 ` Ganesh Mahendran
2014-11-13 13:54 ` Ganesh Mahendran
2014-11-13 14:55 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).