From: David Hildenbrand <david@redhat.com>
To: Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v4 5/6] powerpc/book3s64/memhotplug: Enable memmap on memory for radix
Date: Mon, 24 Jul 2023 17:52:38 +0200 [thread overview]
Message-ID: <141e1000-0c2c-093f-01ea-cd2947fe00e2@redhat.com> (raw)
In-Reply-To: <abd47d75-092f-ba61-d865-168cbf65c842@linux.ibm.com>
>>> + mhp_altmap.base_pfn = PHYS_PFN(start);
>>> + mhp_altmap.free = PHYS_PFN(size) - nr_vmemmap_pages;
>>
>>
>> That change does not belong into this patch.
>>
>
>
> I kept that change with ppc64 enablement because only ppc64 arch got check against
> those values in the free path.
Let's make that accounting consistent in patch #4. I think it really
belongs in there, especially once we clarify the "free vs. reserved"
handling.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-24 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 2:44 [PATCH v4 0/6] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-07-18 2:44 ` [PATCH v4 1/6] mm/hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig Aneesh Kumar K.V
2023-07-18 2:44 ` [PATCH v4 2/6] mm/hotplug: Allow memmap on memory hotplug request to fallback Aneesh Kumar K.V
2023-07-24 12:29 ` David Hildenbrand
2023-07-18 2:44 ` [PATCH v4 3/6] mm/hotplug: Allow architecture to override memmap on memory support check Aneesh Kumar K.V
2023-07-24 12:30 ` David Hildenbrand
2023-07-24 13:47 ` David Hildenbrand
2023-07-18 2:44 ` [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation Aneesh Kumar K.V
2023-07-24 14:33 ` David Hildenbrand
2023-07-24 15:16 ` Aneesh Kumar K V
2023-07-24 15:41 ` David Hildenbrand
2023-07-24 16:02 ` Aneesh Kumar K V
2023-07-24 16:24 ` David Hildenbrand
2023-07-24 17:29 ` Aneesh Kumar K.V
2023-07-18 2:44 ` [PATCH v4 5/6] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
2023-07-24 14:34 ` David Hildenbrand
2023-07-24 14:46 ` Aneesh Kumar K V
2023-07-24 15:52 ` David Hildenbrand [this message]
2023-07-18 2:44 ` [PATCH v4 6/6] mm/hotplug: Embed vmem_altmap details in memory block Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141e1000-0c2c-093f-01ea-cd2947fe00e2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).