From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221B4C001DF for ; Mon, 24 Jul 2023 15:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89FD96B0071; Mon, 24 Jul 2023 11:52:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 850696B0074; Mon, 24 Jul 2023 11:52:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717F06B0075; Mon, 24 Jul 2023 11:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 638336B0071 for ; Mon, 24 Jul 2023 11:52:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 366E6160B2B for ; Mon, 24 Jul 2023 15:52:48 +0000 (UTC) X-FDA: 81046948416.27.B628617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id C14721C0023 for ; Mon, 24 Jul 2023 15:52:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jTsGL+VA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690213965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=23DfRIR5QEmobWx5A5IINKoqO5KQK9NZR/EXIdMN3SQ=; b=gnouBcHhB11GWVRZuTGIYrNAvEurKLUu5eiFK11QoMUldMyauzSXdFFtxG2qjAcIcX5V0J bwu5fmN9uqIgspRSy8KLA4T8nlhe2TmMKSuPgMdMnifkgU6LBN88Wv7ZgZPq+YZCxjaePz m1wEpKuhy83z+elV6nV9DuZ8EZOPQzY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jTsGL+VA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690213965; a=rsa-sha256; cv=none; b=dg1Q8m4if290COy1iwBl2/0pqWESOszaZyS8HjCotQ+qraK15F7yL9T47qapCeeH3AKwGd yW7sox+ZR2tTblF0JB74ZMP+Tm0SpD0zZhOSMnEzKVqfKHZCYZxEN8beMUvB2mUltWD462 RbBE3rnpZgH++030Ss7Pu10uypPpzUA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690213964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23DfRIR5QEmobWx5A5IINKoqO5KQK9NZR/EXIdMN3SQ=; b=jTsGL+VAaziyQot7Z3D/bOnPIB00TysQaprL3P4EZ25eX6khGso6FcGWuzRIGwzUrJAXed 86QGDkqOxDYEc7Pfz2/guBNz/43HkM0u8mdodLvUa+BBIffW26sf/ZaMGABn6I2NdkFnvD t9AEUCHVFq0x2gn+oYiZfAUG9kjlMaM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-z2FUXG56PGq6eODfFjpvgA-1; Mon, 24 Jul 2023 11:52:41 -0400 X-MC-Unique: z2FUXG56PGq6eODfFjpvgA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-2f2981b8364so2707092f8f.1 for ; Mon, 24 Jul 2023 08:52:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690213960; x=1690818760; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=23DfRIR5QEmobWx5A5IINKoqO5KQK9NZR/EXIdMN3SQ=; b=aOtBW3F3tVme7DmV5pMcMtB+WmBR7hypyrzFU6nnFTVDApUrtsdV4y/GnypuBaUPhC Mv0t3F7R32+Wy0/NKulM5fHEica09lSLrOfjh99uC0gIQeQldLktLHAI5WhsCXBYD9Er jAjyiYDYfA/yXQtwKjpNmUMhBr2zeoTxDvpSmYF49Vam8+XLKwKwahyEowfyto58uIfc a/wJUr/i7iYcwca3mC3z9w2Fd0kJxhkxWYCRyTZpKjeK+InfNNV9v/pvlfkBjPI72eIj bapCV2f+mC2M4LoRHiQLscet2M1Rd+LXYFai07Osmc7UGMmh8kHW3YqXB2GTid+F2voa tmaw== X-Gm-Message-State: ABy/qLZIFkIo7AHdSjS13G7zVEfDsu7Cp5OQxQe6Dqs674lFwwQ7YCib frVbK3zFjoVpsVkvqIQbgeizlcCHCnwgMEbnKkYM1UOiE6EnSGCkM3GoOjFH1v5KYWLVwIkjR/F y+na3SmuROEs= X-Received: by 2002:adf:df89:0:b0:314:10c1:881d with SMTP id z9-20020adfdf89000000b0031410c1881dmr7867455wrl.68.1690213960766; Mon, 24 Jul 2023 08:52:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlGvNlSrbtUadtnaU8R8nG66+qRqgvB8WhcithN8FYPh4cr1l0kcFA+eq/ISdpANVwVjUzXMng== X-Received: by 2002:adf:df89:0:b0:314:10c1:881d with SMTP id z9-20020adfdf89000000b0031410c1881dmr7867438wrl.68.1690213960422; Mon, 24 Jul 2023 08:52:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77? (p200300cbc73dbb0091a50d1c3a7e4c77.dip0.t-ipconnect.de. [2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77]) by smtp.gmail.com with ESMTPSA id r9-20020adff709000000b002fb60c7995esm13580880wrp.8.2023.07.24.08.52.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 08:52:39 -0700 (PDT) Message-ID: <141e1000-0c2c-093f-01ea-cd2947fe00e2@redhat.com> Date: Mon, 24 Jul 2023 17:52:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 5/6] powerpc/book3s64/memhotplug: Enable memmap on memory for radix To: Aneesh Kumar K V , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230718024409.95742-1-aneesh.kumar@linux.ibm.com> <20230718024409.95742-6-aneesh.kumar@linux.ibm.com> <7d3a0d68-1d65-a34a-c6c7-80234face7ce@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C14721C0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oz19uar78ez61nkqgmubk33f7iip8wig X-HE-Tag: 1690213965-239781 X-HE-Meta: U2FsdGVkX18EVX1Tn4jU12JCDqr+R+QMu9XRoYrrl4d/lOrEIIHYVLfRYa0tzdb4hYZFVrZyPovq+AHrK0QMe8lRiByV7CZORZZDn3aG7Kcma9xKul2HZ1oYBm8/jQEMunX9cpxfynGfO1BVtH8jMeMF8YBC6nME1oyGRhgNkm2ZXoBpi8EIPTRtJn3C+wMziczKelAEh3jFnlHtuYX8cPyzl4k4dRDB2Nb8FjQNC8Z8pLcjgGotPoXevQVkFnlxCKChCorx/I/oGLgql5apbXLV8bh4AYnM8D194yCGLpcY7yW3uQxKzkt+FR21EaX973Lf7BCrd/wnWPy8mI7FEpG2ZqQizrodWwOBKUjW7QSSGpOOq4ERtVRHU6DId1GJJwxrfeXZT66Bax5x4YXBJM91mphTb32mmihA6UNn4qkpnLxPPL0w+EOa67ioqaUHvHI0IcLtA45Kx+zYmYz5Ns+Ojh07WY/tg+zOKLH/HKIU1isqcLcomXjaeTueQQuDt3Wpi9fNdevFmMZxBITTwc3/Q0N8DfDiMGSH7qwR2KgOKaXmIg2Ge3wMpeH5ed7lfn0ukm2r/y7mPYsIckrrGUxnTG2PA1sGb/ZGQuC8873BeChpKYYFuvWrlnDXtIJanE59RXQv3kY2wsGRuhJIM9zhIqeTzCT00OMDnRQDnkgrMyWpeLeGtInS3Z6lxAFSDUsQB4HLGsL+VHxlBTx56sIgP+pIg4Gn0daMDu0I1yo2yKIDOFiRs/bEtCCfZeR8e0w4kjeAINQwuFkeUGWTFRWrx6nvO60nA3252R352UmgMjUnAMzb0z6azgRrhFEDgwEeS5B7GwS3xSth7SiGMtON7xJYJHAUVE5KDlbtfErz0FVZnlUFjnj88IHaKIrQlsF73RntMyD6Zpqp4lcelVvDgtCeSTGkA+ScFF7sLkgGkOiYaA5hk2Bcjli2Y6OtBzl+zdWt5iF5+qC07rt uNLyqUcw Ep4wFbUWm4ZvSZgVbUo9hdYmmSn8WUKet4DG0I71VyBy6dODrQCQ0y+X2vM+H2Ag0Up5trgSc37qTHcwV4u4HiaZFQKgnLiJXJXT+xP09W1EvKLjlmZ+Mcj2V1VTfpxe/CWYBTeb19TS/O/N7O2wDddltGMLi2SL30lFbPI46iZcfosRnUrgyVvQ2fNyxtOaBysm/jmcjcIinfPYBOzZjIlo4vPMS9WqrHWEeDTgXtjLdLtR2ngEHxVwNGyIfyHN+nkhfUkvyxdCpq8DdhgctkT6h8RKm6JgLDEY+tc3Wj0kfMbUKawcmmQ7pEEXayDPNjxMVO3TMMkcWX56WfFc7FkvVuqG9YE0Ki7eb2Qcws8TtV1EbDyFpgQ3NAhNpjI+G3HO0wmO+IZ2cmqJm+QKgSpX9c7pFUhJEdSlb X-Bogosity: Ham, tests=bogofilter, spamicity=0.019762, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>> +            mhp_altmap.base_pfn = PHYS_PFN(start); >>> +            mhp_altmap.free = PHYS_PFN(size) - nr_vmemmap_pages; >> >> >> That change does not belong into this patch. >> > > > I kept that change with ppc64 enablement because only ppc64 arch got check against > those values in the free path. Let's make that accounting consistent in patch #4. I think it really belongs in there, especially once we clarify the "free vs. reserved" handling. -- Cheers, David / dhildenb