linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org,
	hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org,
	vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org,
	linux-mm@kvack.org, mhocko@suse.cz, Tejun Heo <tj@kernel.org>
Subject: [PATCH 15/16] writeback: add @gfp to wb_init()
Date: Tue,  6 Jan 2015 14:29:16 -0500	[thread overview]
Message-ID: <1420572557-11572-16-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1420572557-11572-1-git-send-email-tj@kernel.org>

wb_init() currently always uses GFP_KERNEL but the planned cgroup
writeback support needs using other allocation masks.  Add @gfp to
wb_init().

This patch doesn't introduce any behavior changes.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Jan Kara <jack@suse.cz>
---
 mm/backing-dev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index a98a957..1c9b70e 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -342,7 +342,8 @@ void wb_wakeup_delayed(struct bdi_writeback *wb)
  */
 #define INIT_BW		(100 << (20 - PAGE_SHIFT))
 
-static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi)
+static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi,
+		   gfp_t gfp)
 {
 	int i, err;
 
@@ -365,12 +366,12 @@ static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi)
 	INIT_LIST_HEAD(&wb->work_list);
 	INIT_DELAYED_WORK(&wb->dwork, wb_workfn);
 
-	err = fprop_local_init_percpu(&wb->completions, GFP_KERNEL);
+	err = fprop_local_init_percpu(&wb->completions, gfp);
 	if (err)
 		return err;
 
 	for (i = 0; i < NR_WB_STAT_ITEMS; i++) {
-		err = percpu_counter_init(&wb->stat[i], 0, GFP_KERNEL);
+		err = percpu_counter_init(&wb->stat[i], 0, gfp);
 		if (err) {
 			while (--i)
 				percpu_counter_destroy(&wb->stat[i]);
@@ -450,7 +451,7 @@ int bdi_init(struct backing_dev_info *bdi)
 	bdi->max_prop_frac = FPROP_FRAC_BASE;
 	INIT_LIST_HEAD(&bdi->bdi_list);
 
-	err = wb_init(&bdi->wb, bdi);
+	err = wb_init(&bdi->wb, bdi, GFP_KERNEL);
 	if (err)
 		return err;
 
-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-01-06 19:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 19:29 [PATCHSET v2 block/for-next] writeback: prepare for cgroup writeback support Tejun Heo
2015-01-06 19:29 ` [PATCH 01/16] blkcg: move block/blk-cgroup.h to include/linux/blk-cgroup.h Tejun Heo
2015-01-06 19:29 ` [PATCH 02/16] update !CONFIG_BLK_CGROUP dummies in include/linux/blk-cgroup.h Tejun Heo
2015-01-06 19:29 ` [PATCH 03/16] blkcg: add blkcg_root_css Tejun Heo
2015-01-06 19:29 ` [PATCH 04/16] cgroup, block: implement task_get_css() and use it in bio_associate_current() Tejun Heo
2015-01-06 19:29 ` [PATCH 05/16] blkcg: implement task_get_blkcg_css() Tejun Heo
2015-01-06 19:29 ` [PATCH 06/16] blkcg: implement bio_associate_blkcg() Tejun Heo
2015-01-06 19:29 ` [PATCH 07/16] writeback: move backing_dev_info->state into bdi_writeback Tejun Heo
2015-01-06 19:29 ` [PATCH 08/16] writeback: move backing_dev_info->bdi_stat[] " Tejun Heo
2015-01-06 19:29 ` [PATCH 09/16] writeback: move bandwidth related fields from backing_dev_info " Tejun Heo
2015-01-06 19:29 ` [PATCH 10/16] writeback: move backing_dev_info->wb_lock and ->worklist " Tejun Heo
2015-01-06 19:29 ` [PATCH 11/16] writeback: move lingering dirty IO lists transfer from bdi_destroy() to wb_exit() Tejun Heo
2015-01-06 19:29 ` [PATCH 12/16] writeback: reorganize mm/backing-dev.c Tejun Heo
2015-01-06 19:29 ` [PATCH 13/16] writeback: separate out include/linux/backing-dev-defs.h Tejun Heo
2015-01-06 19:29 ` [PATCH 14/16] writeback: cosmetic change in account_page_dirtied() Tejun Heo
2015-01-06 19:29 ` Tejun Heo [this message]
2015-01-06 19:29 ` [PATCH 16/16] writeback: move inode_to_bdi() to include/linux/backing-dev.h Tejun Heo
2015-01-07 14:19 ` [PATCHSET v2 block/for-next] writeback: prepare for cgroup writeback support Christoph Hellwig
2015-01-07 15:11   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420572557-11572-16-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@suse.cz \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).