From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by kanga.kvack.org (Postfix) with ESMTP id A20786B0032 for ; Sat, 24 Jan 2015 06:54:17 -0500 (EST) Received: by mail-pa0-f44.google.com with SMTP id rd3so2452385pab.3 for ; Sat, 24 Jan 2015 03:54:17 -0800 (PST) Received: from mx2.parallels.com (mx2.parallels.com. [199.115.105.18]) by mx.google.com with ESMTPS id ky4si5273640pbc.159.2015.01.24.03.54.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Jan 2015 03:54:16 -0800 (PST) From: Vladimir Davydov Subject: [PATCH -mm] slab: suppress warnings caused by expansion of for_each_memcg_cache if !MEMCG_KMEM Date: Sat, 24 Jan 2015 14:53:59 +0300 Message-ID: <1422100439-3980-1-git-send-email-vdavydov@parallels.com> In-Reply-To: <201501240937.DoHGo17V%fengguang.wu@intel.com> References: <201501240937.DoHGo17V%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org In file included from mm/slab_common.c:26:0: mm/slab_common.c: In function 'kmem_cache_destroy': >> mm/slab.h:259:30: warning: right-hand operand of comma expression has no effect [-Wunused-value] for (iter = NULL, tmp = NULL, (root); 0; ) ^ >> mm/slab_common.c:603:2: note: in expansion of macro 'for_each_memcg_cache_safe' for_each_memcg_cache_safe(c, c2, s) { ^ fixes: slab-link-memcg-caches-of-the-same-kind-into-a-list Signed-off-by: Vladimir Davydov --- mm/slab.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/slab.h b/mm/slab.h index 2fc16c2ed198..0a56d76ac0e9 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -254,9 +254,9 @@ extern void slab_init_memcg_params(struct kmem_cache *); #else /* !CONFIG_MEMCG_KMEM */ #define for_each_memcg_cache(iter, root) \ - for (iter = NULL, (root); 0; ) + for ((void)(iter), (void)(root); 0; ) #define for_each_memcg_cache_safe(iter, tmp, root) \ - for (iter = NULL, tmp = NULL, (root); 0; ) + for ((void)(iter), (void)(tmp), (void)(root); 0; ) static inline bool is_root_cache(struct kmem_cache *s) { -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org