From: Sasha Levin <sasha.levin@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, kirill@shutemov.name, linux-mm@kvack.org
Subject: [RFC 02/11] mm: debug: deal with a new family of MM pointers
Date: Tue, 14 Apr 2015 16:56:24 -0400 [thread overview]
Message-ID: <1429044993-1677-3-git-send-email-sasha.levin@oracle.com> (raw)
In-Reply-To: <1429044993-1677-1-git-send-email-sasha.levin@oracle.com>
This teaches our printing functions about a new family of MM pointer that it
could now print.
I've picked %pZ because %pm and %pM were already taken, so I figured it
doesn't really matter what we go with. We also have the option of stealing
one of those two...
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
lib/vsprintf.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 8243e2f..809d19d 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1375,6 +1375,16 @@ char *comm_name(char *buf, char *end, struct task_struct *tsk,
return string(buf, end, name, spec);
}
+static noinline_for_stack
+char *mm_pointer(char *buf, char *end, struct task_struct *tsk,
+ struct printf_spec spec, const char *fmt)
+{
+ switch (fmt[1]) {
+ }
+
+ return buf;
+}
+
int kptr_restrict __read_mostly;
/*
@@ -1463,6 +1473,7 @@ int kptr_restrict __read_mostly;
* (legacy clock framework) of the clock
* - 'Cr' For a clock, it prints the current rate of the clock
* - 'T' task_struct->comm
+ * - 'Z' Outputs a readable version of a type of memory management struct.
*
* Note: The difference between 'S' and 'F' is that on ia64 and ppc64
* function pointers are really function descriptors, which contain a
@@ -1615,6 +1626,8 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
spec, fmt);
case 'T':
return comm_name(buf, end, ptr, spec, fmt);
+ case 'Z':
+ return mm_pointer(buf, end, ptr, spec, fmt);
}
spec.flags |= SMALL;
if (spec.field_width == -1) {
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-14 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 20:56 [RFC 00/11] mm: debug: formatting memory management structs Sasha Levin
2015-04-14 20:56 ` [RFC 01/11] mm: debug: format flags in a buffer Sasha Levin
2015-04-30 15:39 ` Kirill A. Shutemov
2015-04-14 20:56 ` Sasha Levin [this message]
2015-04-30 16:17 ` [RFC 02/11] mm: debug: deal with a new family of MM pointers Kirill A. Shutemov
2015-04-30 16:44 ` Sasha Levin
2015-04-14 20:56 ` [RFC 03/11] mm: debug: dump VMA into a string rather than directly on screen Sasha Levin
2015-04-30 16:18 ` Kirill A. Shutemov
2015-04-14 20:56 ` [RFC 04/11] mm: debug: dump struct MM " Sasha Levin
2015-04-14 20:56 ` [RFC 05/11] mm: debug: dump page " Sasha Levin
2015-04-14 20:56 ` [RFC 06/11] mm: debug: clean unused code Sasha Levin
2015-04-14 20:56 ` [RFC 07/11] mm: debug: VM_BUG() Sasha Levin
2015-04-30 16:22 ` Kirill A. Shutemov
2015-04-14 20:56 ` [RFC 08/11] mm: debug: kill VM_BUG_ON_PAGE Sasha Levin
2015-04-14 20:56 ` [RFC 09/11] mm: debug: kill VM_BUG_ON_VMA Sasha Levin
2015-04-14 20:56 ` [RFC 10/11] mm: debug: kill VM_BUG_ON_MM Sasha Levin
2015-04-14 20:56 ` [RFC 11/11] mm: debug: use VM_BUG() to help with debug output Sasha Levin
2015-04-15 8:45 ` [RFC 00/11] mm: debug: formatting memory management structs Kirill A. Shutemov
2015-04-15 12:52 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429044993-1677-3-git-send-email-sasha.levin@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).