From: David Hildenbrand <dahi@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: dahi@linux.vnet.ibm.com, mingo@redhat.com, peterz@infradead.org,
yang.shi@windriver.com, bigeasy@linutronix.de,
benh@kernel.crashing.org, paulus@samba.org,
akpm@linux-foundation.org, heiko.carstens@de.ibm.com,
schwidefsky@de.ibm.com, borntraeger@de.ibm.com, mst@redhat.com,
tglx@linutronix.de, David.Laight@ACULAB.COM, hughd@google.com,
hocko@suse.cz, ralf@linux-mips.org, herbert@gondor.apana.org.au,
linux@arm.linux.org.uk, airlied@linux.ie,
daniel.vetter@intel.com, linux-mm@kvack.org,
linux-arch@vger.kernel.org
Subject: [PATCH RFC 10/15] arm/futex: UP futex_atomic_cmpxchg_inatomic() relies on disabled preemption
Date: Wed, 6 May 2015 19:50:34 +0200 [thread overview]
Message-ID: <1430934639-2131-11-git-send-email-dahi@linux.vnet.ibm.com> (raw)
In-Reply-To: <1430934639-2131-1-git-send-email-dahi@linux.vnet.ibm.com>
The !CONFIG_SMP implementation of futex_atomic_cmpxchg_inatomic()
requires preemption to be disabled to guarantee mutual exclusion.
Let's make this explicit.
This patch is based on a patch by Sebastian Andrzej Siewior on the
-rt branch.
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
---
arch/arm/include/asm/futex.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/include/asm/futex.h b/arch/arm/include/asm/futex.h
index 4e78065..255bfd1 100644
--- a/arch/arm/include/asm/futex.h
+++ b/arch/arm/include/asm/futex.h
@@ -93,6 +93,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
if (!access_ok(VERIFY_WRITE, uaddr, sizeof(u32)))
return -EFAULT;
+ preempt_disable();
__asm__ __volatile__("@futex_atomic_cmpxchg_inatomic\n"
"1: " TUSER(ldr) " %1, [%4]\n"
" teq %1, %2\n"
@@ -104,6 +105,8 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
: "cc", "memory");
*uval = val;
+ preempt_enable();
+
return ret;
}
--
2.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-06 17:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 17:50 [PATCH RFC 00/15] decouple pagefault_disable() from preempt_disable() David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 01/15] uaccess: count pagefault_disable() levels in pagefault_disabled David Hildenbrand
2015-05-07 10:22 ` Peter Zijlstra
2015-05-07 10:50 ` David Hildenbrand
2015-05-07 11:12 ` Peter Zijlstra
2015-05-07 11:23 ` David Hildenbrand
2015-05-07 11:25 ` Ingo Molnar
2015-05-07 11:30 ` David Hildenbrand
2015-05-07 11:42 ` Peter Zijlstra
2015-05-07 11:40 ` David Hildenbrand
2015-05-07 11:48 ` Peter Zijlstra
2015-05-07 11:51 ` Peter Zijlstra
2015-05-07 12:14 ` David Hildenbrand
2015-05-07 12:27 ` Ingo Molnar
2015-05-07 12:32 ` Peter Zijlstra
2015-05-07 15:45 ` [PATCH draft] mm: use pagefault_disable() to check for disabled pagefaults in the handler David Hildenbrand
2015-05-07 11:12 ` [PATCH RFC 01/15] uaccess: count pagefault_disable() levels in pagefault_disabled Ingo Molnar
2015-05-06 17:50 ` [PATCH RFC 02/15] mm, uaccess: trigger might_sleep() in might_fault() with disabled pagefaults David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 03/15] uaccess: clarify that uaccess may only sleep if pagefaults are enabled David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 04/15] mm: explicitly disable/enable preemption in kmap_atomic_* David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 05/15] mips: kmap_coherent relies on disabled preemption David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 06/15] mm: use pagefault_disabled() to check for disabled pagefaults David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 07/15] drm/i915: " David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 08/15] futex: UP futex_atomic_op_inuser() relies on disabled preemption David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 09/15] futex: UP futex_atomic_cmpxchg_inatomic() " David Hildenbrand
2015-05-06 17:50 ` David Hildenbrand [this message]
2015-05-06 17:50 ` [PATCH RFC 11/15] arm/futex: UP futex_atomic_op_inuser() " David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 12/15] futex: clarify that preemption doesn't have to be disabled David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 13/15] powerpc: enable_kernel_altivec() requires disabled preemption David Hildenbrand
2015-05-07 0:21 ` Benjamin Herrenschmidt
2015-05-06 17:50 ` [PATCH RFC 14/15] mips: properly lock access to the fpu David Hildenbrand
2015-05-06 17:50 ` [PATCH RFC 15/15] uaccess: decouple preemption from the pagefault logic David Hildenbrand
2015-05-06 22:01 ` [PATCH RFC 00/15] decouple pagefault_disable() from preempt_disable() Andrew Morton
2015-05-07 6:23 ` David Hildenbrand
2015-05-07 9:48 ` Ingo Molnar
2015-05-07 10:51 ` Christian Borntraeger
2015-05-07 11:08 ` Ingo Molnar
2015-05-07 11:40 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430934639-2131-11-git-send-email-dahi@linux.vnet.ibm.com \
--to=dahi@linux.vnet.ibm.com \
--cc=David.Laight@ACULAB.COM \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=borntraeger@de.ibm.com \
--cc=daniel.vetter@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=hocko@suse.cz \
--cc=hughd@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=yang.shi@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).