linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov@parallels.com>,
	Tejun Heo <tj@kernel.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/5] memcg: get rid of mem_cgroup_root_css for !CONFIG_MEMCG
Date: Wed, 15 Jul 2015 13:14:42 +0200	[thread overview]
Message-ID: <1436958885-18754-3-git-send-email-mhocko@kernel.org> (raw)
In-Reply-To: <1436958885-18754-1-git-send-email-mhocko@kernel.org>

The only user is cgwb_bdi_init and that one depends on
CONFIG_CGROUP_WRITEBACK which in turn depends on CONFIG_MEMCG
so it doesn't make much sense to definte an empty stub for
!CONFIG_MEMCG. Moreover ERR_PTR(-EINVAL) is ugly and would lead
to runtime crashes if used in unguarded code paths. Better fail
during compilation.

Reviewed-by: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Michal Hocko <mhocko@kernel.org>
---
 include/linux/memcontrol.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 42f118ae04cf..292e6701f3fd 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -497,8 +497,6 @@ void mem_cgroup_split_huge_fixup(struct page *head);
 #else /* CONFIG_MEMCG */
 struct mem_cgroup;
 
-#define mem_cgroup_root_css ((struct cgroup_subsys_state *)ERR_PTR(-EINVAL))
-
 static inline void mem_cgroup_events(struct mem_cgroup *memcg,
 				     enum mem_cgroup_events_index idx,
 				     unsigned int nr)
-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-07-15 11:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 11:14 [PATCH 0/5] expose mem_cgroup + cleanups Michal Hocko
2015-07-15 11:14 ` [PATCH 1/5] memcg: export struct mem_cgroup Michal Hocko
2015-07-15 20:57   ` Andrew Morton
2015-07-16  7:19     ` Michal Hocko
2015-07-16 21:34       ` Andrew Morton
2015-07-16 22:56         ` Johannes Weiner
2015-07-16 23:03           ` Andrew Morton
2015-07-17 12:28             ` Johannes Weiner
2015-07-17 15:18               ` Tejun Heo
2015-07-17 20:19                 ` Andrew Morton
2015-07-20 11:49                   ` Michal Hocko
2015-07-24  8:17                     ` Michal Hocko
2015-07-20 11:23               ` Michal Hocko
2015-07-20 22:43                 ` Andrew Morton
2015-07-21 12:55                   ` Michal Hocko
2015-07-15 11:14 ` Michal Hocko [this message]
2015-07-15 11:14 ` [PATCH 3/5] memcg: get rid of extern for functions in memcontrol.h Michal Hocko
2015-07-15 11:14 ` [PATCH 4/5] memcg: restructure mem_cgroup_can_attach() Michal Hocko
2015-07-15 11:14 ` [PATCH 5/5] memcg, tcp_kmem: check for cg_proto in sock_update_memcg Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436958885-18754-3-git-send-email-mhocko@kernel.org \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).