From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Steve Capper <steve.capper@linaro.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Jerome Marchand <jmarchan@redhat.com>,
Sasha Levin <sasha.levin@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv9 22/36] sparc, thp: remove infrastructure for handling splitting PMDs
Date: Mon, 20 Jul 2015 17:20:55 +0300 [thread overview]
Message-ID: <1437402069-105900-23-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1437402069-105900-1-git-send-email-kirill.shutemov@linux.intel.com>
With new refcounting we don't need to mark PMDs splitting. Let's drop
code to handle this.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
arch/sparc/include/asm/pgtable_64.h | 16 ----------------
arch/sparc/mm/fault_64.c | 3 ---
arch/sparc/mm/gup.c | 2 +-
3 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h
index 5833dc5ee7d7..7a38d6a576c5 100644
--- a/arch/sparc/include/asm/pgtable_64.h
+++ b/arch/sparc/include/asm/pgtable_64.h
@@ -681,13 +681,6 @@ static inline unsigned long pmd_trans_huge(pmd_t pmd)
return pte_val(pte) & _PAGE_PMD_HUGE;
}
-static inline unsigned long pmd_trans_splitting(pmd_t pmd)
-{
- pte_t pte = __pte(pmd_val(pmd));
-
- return pmd_trans_huge(pmd) && pte_special(pte);
-}
-
#define has_transparent_hugepage() 1
static inline pmd_t pmd_mkold(pmd_t pmd)
@@ -744,15 +737,6 @@ static inline pmd_t pmd_mkwrite(pmd_t pmd)
return __pmd(pte_val(pte));
}
-static inline pmd_t pmd_mksplitting(pmd_t pmd)
-{
- pte_t pte = __pte(pmd_val(pmd));
-
- pte = pte_mkspecial(pte);
-
- return __pmd(pte_val(pte));
-}
-
static inline pgprot_t pmd_pgprot(pmd_t entry)
{
unsigned long val = pmd_val(entry);
diff --git a/arch/sparc/mm/fault_64.c b/arch/sparc/mm/fault_64.c
index 479823249429..a504a4d85ebd 100644
--- a/arch/sparc/mm/fault_64.c
+++ b/arch/sparc/mm/fault_64.c
@@ -113,9 +113,6 @@ static unsigned int get_user_insn(unsigned long tpc)
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
if (pmd_trans_huge(*pmdp)) {
- if (pmd_trans_splitting(*pmdp))
- goto out_irq_enable;
-
pa = pmd_pfn(*pmdp) << PAGE_SHIFT;
pa += tpc & ~HPAGE_MASK;
diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
index 9091c5daa2e1..eb3d8e8ebc6b 100644
--- a/arch/sparc/mm/gup.c
+++ b/arch/sparc/mm/gup.c
@@ -114,7 +114,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
pmd_t pmd = *pmdp;
next = pmd_addr_end(addr, end);
- if (pmd_none(pmd) || pmd_trans_splitting(pmd))
+ if (pmd_none(pmd))
return 0;
if (unlikely(pmd_large(pmd))) {
if (!gup_huge_pmd(pmdp, pmd, addr, next,
--
2.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-20 14:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:20 [PATCHv9 00/36] THP refcounting redesign Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 01/36] mm, proc: adjust PSS calculation Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 02/36] rmap: add argument to charge compound page Kirill A. Shutemov
2015-07-31 14:45 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 03/36] memcg: adjust to support new THP refcounting Kirill A. Shutemov
2015-07-31 14:46 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 04/36] mm, thp: adjust conditions when we can reuse the page on WP fault Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 05/36] mm: adjust FOLL_SPLIT for new refcounting Kirill A. Shutemov
2015-07-31 14:47 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 06/36] mm: handle PTE-mapped tail pages in gerneric fast gup implementaiton Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 07/36] thp, mlock: do not allow huge pages in mlocked area Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 08/36] khugepaged: ignore pmd tables with THP mapped with ptes Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 09/36] thp: rename split_huge_page_pmd() to split_huge_pmd() Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 10/36] mm, vmstats: new THP splitting event Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 11/36] mm: temporally mark THP broken Kirill A. Shutemov
2015-07-31 14:50 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 12/36] thp: drop all split_huge_page()-related code Kirill A. Shutemov
2015-07-31 14:50 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 13/36] mm: drop tail page refcounting Kirill A. Shutemov
2015-07-31 14:51 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 14/36] futex, thp: remove special case for THP in get_futex_key Kirill A. Shutemov
2015-07-31 14:52 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 15/36] ksm: prepare to new THP semantics Kirill A. Shutemov
2015-07-31 14:53 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 16/36] mm, thp: remove compound_lock Kirill A. Shutemov
2015-07-31 14:53 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 17/36] arm64, thp: remove infrastructure for handling splitting PMDs Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 18/36] arm, " Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 19/36] mips, " Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 20/36] powerpc, " Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 21/36] s390, " Kirill A. Shutemov
2015-07-20 14:20 ` Kirill A. Shutemov [this message]
2015-07-20 14:20 ` [PATCHv9 23/36] tile, " Kirill A. Shutemov
2015-07-20 14:20 ` [PATCHv9 24/36] x86, " Kirill A. Shutemov
2015-07-31 14:54 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 25/36] mm, " Kirill A. Shutemov
2015-07-31 15:01 ` Jerome Marchand
2015-08-03 10:41 ` Kirill A. Shutemov
2015-08-03 11:40 ` Jerome Marchand
2015-07-20 14:20 ` [PATCHv9 26/36] mm: rework mapcount accounting to enable 4k mapping of THPs Kirill A. Shutemov
2015-07-31 15:04 ` Jerome Marchand
2015-08-03 10:43 ` Kirill A. Shutemov
2015-08-03 11:41 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 27/36] mm: differentiate page_mapped() from page_mapcount() for compound pages Kirill A. Shutemov
2015-07-31 15:04 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 28/36] mm, numa: skip PTE-mapped THP on numa fault Kirill A. Shutemov
2015-07-31 15:06 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 29/36] thp: implement split_huge_pmd() Kirill A. Shutemov
2015-07-31 15:06 ` Jerome Marchand
2015-08-03 10:44 ` Kirill A. Shutemov
2015-07-20 14:21 ` [PATCHv9 30/36] thp: add option to setup migration entiries during PMD split Kirill A. Shutemov
2015-07-31 15:09 ` Jerome Marchand
2015-08-03 10:53 ` Kirill A. Shutemov
2015-07-20 14:21 ` [PATCHv9 31/36] thp, mm: split_huge_page(): caller need to lock page Kirill A. Shutemov
2015-07-31 15:12 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 32/36] thp: reintroduce split_huge_page() Kirill A. Shutemov
2015-07-31 15:13 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 33/36] migrate_pages: try to split pages on qeueuing Kirill A. Shutemov
2015-07-31 15:14 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 34/36] thp: introduce deferred_split_huge_page() Kirill A. Shutemov
2015-07-31 15:14 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 35/36] mm: re-enable THP Kirill A. Shutemov
2015-07-31 15:15 ` Jerome Marchand
2015-07-20 14:21 ` [PATCHv9 36/36] thp: update documentation Kirill A. Shutemov
2015-07-31 15:16 ` Jerome Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437402069-105900-23-git-send-email-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cl@gentwo.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=steve.capper@linaro.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).