From: Baoquan He <bhe@redhat.com>
To: tj@kernel.org, cl@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: Baoquan He <bhe@redhat.com>
Subject: [PATCH 2/3] perpuc: check pcpu_first_chunk and pcpu_reserved_chunk to avoid handling them twice
Date: Mon, 20 Jul 2015 22:55:29 +0800 [thread overview]
Message-ID: <1437404130-5188-2-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1437404130-5188-1-git-send-email-bhe@redhat.com>
In pcpu_setup_first_chunk() pcpu_reserved_chunk is assigned to point to
static chunk. While pcpu_first_chunk is got from below code:
pcpu_first_chunk = dchunk ?: schunk;
Then it could point to static chunk too if dynamic chunk doesn't exist. So
in this patch adding a check in percpu_init_late() to see if pcpu_first_chunk
is equal to pcpu_reserved_chunk. Only if they are not equal we add
pcpu_reserved_chunk to the target array.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/percpu.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index a63b4d8..f7e02c0 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -2260,11 +2260,18 @@ void __init setup_per_cpu_areas(void)
void __init percpu_init_late(void)
{
struct pcpu_chunk *target_chunks[] =
- { pcpu_first_chunk, pcpu_reserved_chunk, NULL };
+ { pcpu_first_chunk, NULL, NULL };
struct pcpu_chunk *chunk;
unsigned long flags;
int i;
+ /*
+ * pcpu_first_chunk could be the same as pcpu_reserved_chunk, add it to the
+ * target array only if pcpu_first_chunk is not equal to pcpu_reserved_chunk.
+ */
+ if (pcpu_first_chunk != pcpu_reserved_chunk)
+ target_chunks[1] = pcpu_reserved_chunk;
+
for (i = 0; (chunk = target_chunks[i]); i++) {
int *map;
const size_t size = PERCPU_DYNAMIC_EARLY_SLOTS * sizeof(map[0]);
--
1.9.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-20 14:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:55 [PATCH 1/3] percpu: clean up of schunk->map[] assignment in pcpu_setup_first_chunk Baoquan He
2015-07-20 14:55 ` Baoquan He [this message]
2015-07-21 15:28 ` [PATCH 2/3] perpuc: check pcpu_first_chunk and pcpu_reserved_chunk to avoid handling them twice Tejun Heo
2015-07-22 0:03 ` Baoquan He
2015-07-22 13:52 ` Tejun Heo
2015-07-22 14:29 ` Baoquan He
2015-07-22 14:37 ` Tejun Heo
2015-07-23 1:56 ` Baoquan He
2015-07-23 1:53 ` [PATCH v3 2/3] percpu: Add WARN_ON into percpu_init_late Baoquan He
2015-07-20 14:55 ` [PATCH 3/3] percpu: add macro PCPU_CHUNK_AREA_IN_USE Baoquan He
2015-07-20 15:35 ` Christoph Lameter
2015-07-22 0:25 ` Baoquan He
2015-07-21 15:30 ` Tejun Heo
2015-07-22 0:28 ` Baoquan He
2015-07-22 13:53 ` Tejun Heo
2015-07-23 1:55 ` Baoquan He
2015-07-23 1:50 ` [PATCH v2 3/3] percpu: add macro PCPU_MAP_BUSY Baoquan He
2015-07-20 15:32 ` [PATCH 1/3] percpu: clean up of schunk->map[] assignment in pcpu_setup_first_chunk Christoph Lameter
2015-07-21 15:33 ` Tejun Heo
2015-07-22 0:56 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437404130-5188-2-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).