From: Baoquan He <bhe@redhat.com>
To: tj@kernel.org, cl@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: Baoquan He <bhe@redhat.com>
Subject: [PATCH 3/3] percpu: add macro PCPU_CHUNK_AREA_IN_USE
Date: Mon, 20 Jul 2015 22:55:30 +0800 [thread overview]
Message-ID: <1437404130-5188-3-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1437404130-5188-1-git-send-email-bhe@redhat.com>
chunk->map[] contains <offset|in-use flag> of each area. Now add a
new macro PCPU_CHUNK_AREA_IN_USE and use it as the in-use flag to
replace all magic number '1'.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/percpu.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index f7e02c0..2f99073 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -80,6 +80,7 @@
#define PCPU_ATOMIC_MAP_MARGIN_HIGH 64
#define PCPU_EMPTY_POP_PAGES_LOW 2
#define PCPU_EMPTY_POP_PAGES_HIGH 4
+#define PCPU_CHUNK_AREA_IN_USE 1
#ifdef CONFIG_SMP
/* default addr <-> pcpu_ptr mapping, override in asm/percpu.h if necessary */
@@ -328,8 +329,8 @@ static void pcpu_mem_free(void *ptr, size_t size)
*/
static int pcpu_count_occupied_pages(struct pcpu_chunk *chunk, int i)
{
- int off = chunk->map[i] & ~1;
- int end = chunk->map[i + 1] & ~1;
+ int off = chunk->map[i] & ~PCPU_CHUNK_AREA_IN_USE;
+ int end = chunk->map[i + 1] & ~PCPU_CHUNK_AREA_IN_USE;
if (!PAGE_ALIGNED(off) && i > 0) {
int prev = chunk->map[i - 1];
@@ -340,7 +341,7 @@ static int pcpu_count_occupied_pages(struct pcpu_chunk *chunk, int i)
if (!PAGE_ALIGNED(end) && i + 1 < chunk->map_used) {
int next = chunk->map[i + 1];
- int nend = chunk->map[i + 2] & ~1;
+ int nend = chunk->map[i + 2] & ~PCPU_CHUNK_AREA_IN_USE;
if (!(next & 1) && nend >= round_up(end, PAGE_SIZE))
end = round_up(end, PAGE_SIZE);
@@ -738,7 +739,7 @@ static struct pcpu_chunk *pcpu_alloc_chunk(void)
chunk->map_alloc = PCPU_DFL_MAP_ALLOC;
chunk->map[0] = 0;
- chunk->map[1] = pcpu_unit_size | 1;
+ chunk->map[1] = pcpu_unit_size | PCPU_CHUNK_AREA_IN_USE;
chunk->map_used = 1;
INIT_LIST_HEAD(&chunk->list);
@@ -1664,12 +1665,12 @@ int __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai,
}
schunk->contig_hint = schunk->free_size;
- schunk->map[0] = 1;
+ schunk->map[0] = PCPU_CHUNK_AREA_IN_USE;
schunk->map[1] = ai->static_size;
schunk->map_used = 1;
if (schunk->free_size)
schunk->map[++schunk->map_used] = ai->static_size + schunk->free_size;
- schunk->map[schunk->map_used] |= 1;
+ schunk->map[schunk->map_used] |= PCPU_CHUNK_AREA_IN_USE;
/* init dynamic chunk if necessary */
if (dyn_size) {
@@ -1684,9 +1685,10 @@ int __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai,
dchunk->nr_populated = pcpu_unit_pages;
dchunk->contig_hint = dchunk->free_size = dyn_size;
- dchunk->map[0] = 1;
+ dchunk->map[0] = PCPU_CHUNK_AREA_IN_USE;
dchunk->map[1] = pcpu_reserved_chunk_limit;
- dchunk->map[2] = (pcpu_reserved_chunk_limit + dchunk->free_size) | 1;
+ dchunk->map[2] = (pcpu_reserved_chunk_limit + dchunk->free_size)
+ | PCPU_CHUNK_AREA_IN_USE;
dchunk->map_used = 2;
}
--
1.9.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-20 14:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:55 [PATCH 1/3] percpu: clean up of schunk->map[] assignment in pcpu_setup_first_chunk Baoquan He
2015-07-20 14:55 ` [PATCH 2/3] perpuc: check pcpu_first_chunk and pcpu_reserved_chunk to avoid handling them twice Baoquan He
2015-07-21 15:28 ` Tejun Heo
2015-07-22 0:03 ` Baoquan He
2015-07-22 13:52 ` Tejun Heo
2015-07-22 14:29 ` Baoquan He
2015-07-22 14:37 ` Tejun Heo
2015-07-23 1:56 ` Baoquan He
2015-07-23 1:53 ` [PATCH v3 2/3] percpu: Add WARN_ON into percpu_init_late Baoquan He
2015-07-20 14:55 ` Baoquan He [this message]
2015-07-20 15:35 ` [PATCH 3/3] percpu: add macro PCPU_CHUNK_AREA_IN_USE Christoph Lameter
2015-07-22 0:25 ` Baoquan He
2015-07-21 15:30 ` Tejun Heo
2015-07-22 0:28 ` Baoquan He
2015-07-22 13:53 ` Tejun Heo
2015-07-23 1:55 ` Baoquan He
2015-07-23 1:50 ` [PATCH v2 3/3] percpu: add macro PCPU_MAP_BUSY Baoquan He
2015-07-20 15:32 ` [PATCH 1/3] percpu: clean up of schunk->map[] assignment in pcpu_setup_first_chunk Christoph Lameter
2015-07-21 15:33 ` Tejun Heo
2015-07-22 0:56 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437404130-5188-3-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).