linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: linux-kernel@vger.kernel.org
Cc: David Vrabel <david.vrabel@citrix.com>,
	linux-mm@kvack.org, Robin Holt <holt@sgi.com>,
	Nathan Zimmer <nzimmer@sgi.com>, Mel Gorman <mgorman@suse.de>
Subject: [PATCHv1] mm: always initialize pages as reserved to fix memory hotplug
Date: Thu, 30 Jul 2015 15:04:43 +0100	[thread overview]
Message-ID: <1438265083-31208-1-git-send-email-david.vrabel@citrix.com> (raw)

Commit 92923ca3aacef63c92dc297a75ad0c6dfe4eab37 (mm: meminit: only set
page reserved in the memblock region) breaks memory hotplug because pages
within newly added sections are not marked as reserved as required by
the memory hotplug driver.  If pages within an offline section are not
reserved, the secton cannot be onlined.

Re-add the SetPageReserved() call.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Cc: Robin Holt <holt@sgi.com>
Cc: Nathan Zimmer <nzimmer@sgi.com>
Cc: Mel Gorman <mgorman@suse.de>
---
 mm/page_alloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ef19f22..89492f6 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -842,6 +842,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn,
 	init_page_count(page);
 	page_mapcount_reset(page);
 	page_cpupid_reset_last(page);
+	SetPageReserved(page);
 
 	INIT_LIST_HEAD(&page->lru);
 #ifdef WANT_PAGE_VIRTUAL
-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2015-07-30 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 14:04 David Vrabel [this message]
2015-07-30 14:45 ` [PATCHv1] mm: always initialize pages as reserved to fix memory hotplug Mel Gorman
2015-07-30 16:41   ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438265083-31208-1-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=nzimmer@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).