linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: David Vrabel <david.vrabel@citrix.com>,
	linux-mm@kvack.org,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCHv3 09/10] x86/xen: export xen_alloc_p2m_entry()
Date: Thu, 30 Jul 2015 18:03:11 +0100	[thread overview]
Message-ID: <1438275792-5726-10-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1438275792-5726-1-git-send-email-david.vrabel@citrix.com>

Rename alloc_p2m() to xen_alloc_p2m_entry() and export it.

This is useful for ensuring that a p2m entry is allocated (i.e., not a
shared missing or identity entry) so that subsequent set_phys_to_machine()
calls will require no further allocations.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
v3:
- Make xen_alloc_p2m_entry() a nop on auto-xlate guests.
---
 arch/x86/include/asm/xen/page.h |  2 ++
 arch/x86/xen/p2m.c              | 19 +++++++++++++------
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h
index c44a5d5..960b380 100644
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -45,6 +45,8 @@ extern unsigned long *xen_p2m_addr;
 extern unsigned long  xen_p2m_size;
 extern unsigned long  xen_max_p2m_pfn;
 
+extern int xen_alloc_p2m_entry(unsigned long pfn);
+
 extern unsigned long get_phys_to_machine(unsigned long pfn);
 extern bool set_phys_to_machine(unsigned long pfn, unsigned long mfn);
 extern bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 8b7f18e..0215897 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -503,7 +503,7 @@ static pte_t *alloc_p2m_pmd(unsigned long addr, pte_t *pte_pg)
  * the new pages are installed with cmpxchg; if we lose the race then
  * simply free the page we allocated and use the one that's there.
  */
-static bool alloc_p2m(unsigned long pfn)
+int xen_alloc_p2m_entry(unsigned long pfn)
 {
 	unsigned topidx, mididx;
 	unsigned long *top_mfn_p, *mid_mfn;
@@ -513,6 +513,9 @@ static bool alloc_p2m(unsigned long pfn)
 	unsigned long addr = (unsigned long)(xen_p2m_addr + pfn);
 	unsigned long p2m_pfn;
 
+	if (xen_feature(XENFEAT_auto_translated_physmap))
+		return 0;
+
 	topidx = p2m_top_index(pfn);
 	mididx = p2m_mid_index(pfn);
 
@@ -524,7 +527,7 @@ static bool alloc_p2m(unsigned long pfn)
 		/* PMD level is missing, allocate a new one */
 		ptep = alloc_p2m_pmd(addr, pte_pg);
 		if (!ptep)
-			return false;
+			return -ENOMEM;
 	}
 
 	if (p2m_top_mfn) {
@@ -541,7 +544,7 @@ static bool alloc_p2m(unsigned long pfn)
 
 			mid_mfn = alloc_p2m_page();
 			if (!mid_mfn)
-				return false;
+				return -ENOMEM;
 
 			p2m_mid_mfn_init(mid_mfn, p2m_missing);
 
@@ -567,7 +570,7 @@ static bool alloc_p2m(unsigned long pfn)
 
 		p2m = alloc_p2m_page();
 		if (!p2m)
-			return false;
+			return -ENOMEM;
 
 		if (p2m_pfn == PFN_DOWN(__pa(p2m_missing)))
 			p2m_init(p2m);
@@ -590,8 +593,9 @@ static bool alloc_p2m(unsigned long pfn)
 			free_p2m_page(p2m);
 	}
 
-	return true;
+	return 0;
 }
+EXPORT_SYMBOL(xen_alloc_p2m_entry);
 
 unsigned long __init set_phys_range_identity(unsigned long pfn_s,
 				      unsigned long pfn_e)
@@ -648,7 +652,10 @@ bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 {
 	if (unlikely(!__set_phys_to_machine(pfn, mfn))) {
-		if (!alloc_p2m(pfn))
+		int ret;
+
+		ret = xen_alloc_p2m_entry(pfn);
+		if (ret < 0)
 			return false;
 
 		return __set_phys_to_machine(pfn, mfn);
-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-07-30 17:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 17:03 [PATCHv3 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel
2015-07-30 17:03 ` [PATCHv3 01/10] mm: memory hotplug with an existing resource David Vrabel
2015-07-31 23:15   ` Daniel Kiper
2015-08-13 10:21   ` [Xen-devel] " David Vrabel
2015-08-13 20:40     ` Andrew Morton
2015-08-16 11:41       ` Tang Chen
2015-07-30 17:03 ` [PATCHv3 02/10] xen/balloon: remove scratch page left overs David Vrabel
2015-07-30 17:03 ` [PATCHv3 03/10] x86/xen: discard RAM regions above the maximum reservation David Vrabel
2015-07-30 17:03 ` [PATCHv3 04/10] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel
2015-07-30 17:03 ` [PATCHv3 05/10] xen/balloon: rationalize memory hotplug stats David Vrabel
2015-07-30 17:03 ` [PATCHv3 06/10] xen/balloon: only hotplug additional memory if required David Vrabel
2015-07-31 23:18   ` Daniel Kiper
2015-07-30 17:03 ` [PATCHv3 07/10] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel
2015-07-30 17:03 ` [PATCHv3 08/10] xen/balloon: use hotplugged pages for foreign mappings etc David Vrabel
2015-07-31 23:20   ` Daniel Kiper
2015-07-30 17:03 ` David Vrabel [this message]
2015-07-31 23:22   ` [PATCHv3 09/10] x86/xen: export xen_alloc_p2m_entry() Daniel Kiper
2015-07-30 17:03 ` [PATCHv3 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages David Vrabel
2015-07-31 23:23   ` Daniel Kiper
2015-09-29 16:24 ` [Xen-devel] [PATCHv3 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438275792-5726-10-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).