linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: David Vrabel <david.vrabel@citrix.com>,
	linux-mm@kvack.org,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCHv3 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages
Date: Thu, 30 Jul 2015 18:03:12 +0100	[thread overview]
Message-ID: <1438275792-5726-11-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1438275792-5726-1-git-send-email-david.vrabel@citrix.com>

Pages returned by alloc_xenballooned_pages() will be used for grant
mapping which will call set_phys_to_machine() (in PV guests).

Ballooned pages are set as INVALID_P2M_ENTRY in the p2m and thus may
be using the (shared) missing tables and a subsequent
set_phys_to_machine() will need to allocate new tables.

Since the grant mapping may be done from a context that cannot sleep,
the p2m entries must already be allocated.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
 drivers/xen/balloon.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 3094f38f..e040cf4 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -593,6 +593,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 {
 	int pgno = 0;
 	struct page *page;
+	int ret = -ENOMEM;
 
 	mutex_lock(&balloon_mutex);
 
@@ -602,6 +603,11 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 		page = balloon_retrieve(true);
 		if (page) {
 			pages[pgno++] = page;
+#ifdef CONFIG_XEN_HAVE_PVMMU
+			ret = xen_alloc_p2m_entry(page_to_pfn(page));
+			if (ret < 0)
+				goto out_undo;
+#endif
 		} else {
 			ret = add_ballooned_pages(nr_pages - pgno);
 			if (ret < 0)
@@ -613,7 +619,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
  out_undo:
 	mutex_unlock(&balloon_mutex);
 	free_xenballooned_pages(pgno, pages);
-	return -ENOMEM;
+	return ret;
 }
 EXPORT_SYMBOL(alloc_xenballooned_pages);
 
-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-07-30 17:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 17:03 [PATCHv3 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel
2015-07-30 17:03 ` [PATCHv3 01/10] mm: memory hotplug with an existing resource David Vrabel
2015-07-31 23:15   ` Daniel Kiper
2015-08-13 10:21   ` [Xen-devel] " David Vrabel
2015-08-13 20:40     ` Andrew Morton
2015-08-16 11:41       ` Tang Chen
2015-07-30 17:03 ` [PATCHv3 02/10] xen/balloon: remove scratch page left overs David Vrabel
2015-07-30 17:03 ` [PATCHv3 03/10] x86/xen: discard RAM regions above the maximum reservation David Vrabel
2015-07-30 17:03 ` [PATCHv3 04/10] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel
2015-07-30 17:03 ` [PATCHv3 05/10] xen/balloon: rationalize memory hotplug stats David Vrabel
2015-07-30 17:03 ` [PATCHv3 06/10] xen/balloon: only hotplug additional memory if required David Vrabel
2015-07-31 23:18   ` Daniel Kiper
2015-07-30 17:03 ` [PATCHv3 07/10] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel
2015-07-30 17:03 ` [PATCHv3 08/10] xen/balloon: use hotplugged pages for foreign mappings etc David Vrabel
2015-07-31 23:20   ` Daniel Kiper
2015-07-30 17:03 ` [PATCHv3 09/10] x86/xen: export xen_alloc_p2m_entry() David Vrabel
2015-07-31 23:22   ` Daniel Kiper
2015-07-30 17:03 ` David Vrabel [this message]
2015-07-31 23:23   ` [PATCHv3 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages Daniel Kiper
2015-09-29 16:24 ` [Xen-devel] [PATCHv3 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438275792-5726-11-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).