From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f182.google.com (mail-qk0-f182.google.com [209.85.220.182]) by kanga.kvack.org (Postfix) with ESMTP id E117782F61 for ; Thu, 13 Aug 2015 15:38:23 -0400 (EDT) Received: by qkbm65 with SMTP id m65so18981199qkb.2 for ; Thu, 13 Aug 2015 12:38:23 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id 136si5457614qhx.54.2015.08.13.12.38.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2015 12:38:23 -0700 (PDT) From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= Subject: [PATCH 13/15] HMM: CPU page fault on migrated memory. Date: Thu, 13 Aug 2015 15:37:29 -0400 Message-Id: <1439494651-1255-14-git-send-email-jglisse@redhat.com> In-Reply-To: <1439494651-1255-1-git-send-email-jglisse@redhat.com> References: <1439494651-1255-1-git-send-email-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Linus Torvalds , joro@8bytes.org, Mel Gorman , "H. Peter Anvin" , Peter Zijlstra , Andrea Arcangeli , Johannes Weiner , Larry Woodman , Rik van Riel , Dave Airlie , Brendan Conoboy , Joe Donohue , Christophe Harle , Duncan Poole , Sherry Cheung , Subhash Gutti , John Hubbard , Mark Hairgrove , Lucien Dunning , Cameron Buschardt , Arvind Gopalakrishnan , Haggai Eran , Shachar Raindel , Liran Liss , Roland Dreier , Ben Sander , Greg Stoner , John Bridgman , Michael Mantor , Paul Blinzer , Leonid Shamis , Laurent Morichetti , Alexander Deucher , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= When CPU try to access memory that have been migrated to device memory we have to copy it back to system memory. This patch implement the CPU page fault handler for special HMM pte swap entry. Signed-off-by: JA(C)rA'me Glisse --- mm/hmm.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/mm/hmm.c b/mm/hmm.c index e23b264..97193e6 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -469,7 +469,59 @@ int hmm_handle_cpu_fault(struct mm_struct *mm, pmd_t *pmdp, unsigned long addr, unsigned flags, pte_t orig_pte) { - return VM_FAULT_SIGBUS; + unsigned long start, end; + struct hmm_event event; + swp_entry_t entry; + struct hmm *hmm; + dma_addr_t dst; + pte_t new_pte; + int ret; + + /* First check for poisonous entry. */ + entry = pte_to_swp_entry(orig_pte); + if (is_hmm_entry_poisonous(entry)) + return VM_FAULT_SIGBUS; + + hmm = hmm_ref(mm->hmm); + if (!hmm) { + pte_t poison = swp_entry_to_pte(make_hmm_entry_poisonous()); + spinlock_t *ptl; + pte_t *ptep; + + /* Check if cpu pte is already updated. */ + ptep = pte_offset_map_lock(mm, pmdp, addr, &ptl); + if (!pte_same(*ptep, orig_pte)) { + pte_unmap_unlock(ptep, ptl); + return 0; + } + set_pte_at(mm, addr, ptep, poison); + pte_unmap_unlock(ptep, ptl); + return VM_FAULT_SIGBUS; + } + + /* + * TODO we likely want to migrate more then one page at a time, we need + * to call into the device driver to get good hint on the range to copy + * back to system memory. + * + * For now just live with the one page at a time solution. + */ + start = addr & PAGE_MASK; + end = start + PAGE_SIZE; + hmm_event_init(&event, hmm, start, end, HMM_COPY_FROM_DEVICE); + + ret = hmm_migrate_back(hmm, &event, mm, vma, &new_pte, + &dst, start, end); + hmm_unref(hmm); + switch (ret) { + case 0: + return VM_FAULT_MAJOR; + case -ENOMEM: + return VM_FAULT_OOM; + case -EINVAL: + default: + return VM_FAULT_SIGBUS; + } } EXPORT_SYMBOL(hmm_handle_cpu_fault); -- 1.9.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org