From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv3 2/5] zsmalloc: use page->private instead of page->first_page
Date: Wed, 19 Aug 2015 12:21:43 +0300 [thread overview]
Message-ID: <1439976106-137226-3-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com>
We are going to rework how compound_head() work. It will not use
page->first_page as we have it now.
The only other user of page->fisrt_page beyond compound pages is
zsmalloc.
Let's use page->private instead of page->first_page here. It occupies
the same storage space.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/zsmalloc.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 0a7f81aa2249..a85754e69879 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -16,7 +16,7 @@
* struct page(s) to form a zspage.
*
* Usage of struct page fields:
- * page->first_page: points to the first component (0-order) page
+ * page->private: points to the first component (0-order) page
* page->index (union with page->freelist): offset of the first object
* starting in this page. For the first page, this is
* always 0, so we use this field (aka freelist) to point
@@ -26,8 +26,7 @@
*
* For _first_ page only:
*
- * page->private (union with page->first_page): refers to the
- * component page after the first page
+ * page->private: refers to the component page after the first page
* If the page is first_page for huge object, it stores handle.
* Look at size_class->huge.
* page->freelist: points to the first free object in zspage.
@@ -770,7 +769,7 @@ static struct page *get_first_page(struct page *page)
if (is_first_page(page))
return page;
else
- return page->first_page;
+ return (struct page *)page_private(page);
}
static struct page *get_next_page(struct page *page)
@@ -955,7 +954,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
* Allocate individual pages and link them together as:
* 1. first page->private = first sub-page
* 2. all sub-pages are linked together using page->lru
- * 3. each sub-page is linked to the first page using page->first_page
+ * 3. each sub-page is linked to the first page using page->private
*
* For each size class, First/Head pages are linked together using
* page->lru. Also, we set PG_private to identify the first page
@@ -980,7 +979,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
if (i == 1)
set_page_private(first_page, (unsigned long)page);
if (i >= 1)
- page->first_page = first_page;
+ set_page_private(first_page, (unsigned long)first_page);
if (i >= 2)
list_add(&page->lru, &prev_page->lru);
if (i == class->pages_per_zspage - 1) /* last page */
--
2.5.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-19 9:21 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 9:21 [PATCHv3 0/5] Fix compound_head() race Kirill A. Shutemov
2015-08-19 9:21 ` [PATCHv3 1/5] mm: drop page->slab_page Kirill A. Shutemov
2015-08-24 14:59 ` Vlastimil Babka
2015-08-24 15:02 ` Vlastimil Babka
2015-08-25 17:24 ` Kirill A. Shutemov
2015-08-19 9:21 ` Kirill A. Shutemov [this message]
2015-08-24 15:04 ` [PATCHv3 2/5] zsmalloc: use page->private instead of page->first_page Vlastimil Babka
2015-08-19 9:21 ` [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one word in struct page Kirill A. Shutemov
2015-08-20 23:26 ` Andrew Morton
2015-08-21 7:13 ` Michal Hocko
2015-08-21 10:40 ` Kirill A. Shutemov
2015-08-21 10:51 ` Michal Hocko
2015-08-19 9:21 ` [PATCHv3 4/5] mm: make compound_head() robust Kirill A. Shutemov
2015-08-20 23:36 ` Andrew Morton
2015-08-21 12:10 ` Kirill A. Shutemov
2015-08-21 16:11 ` Christoph Lameter
2015-08-21 19:31 ` Kirill A. Shutemov
2015-08-21 19:34 ` Andrew Morton
2015-08-21 21:15 ` Christoph Lameter
2015-08-24 15:49 ` Vlastimil Babka
2015-08-25 11:44 ` Vlastimil Babka
2015-08-25 18:33 ` Kirill A. Shutemov
2015-08-25 20:11 ` Paul E. McKenney
2015-08-25 20:46 ` Vlastimil Babka
2015-08-25 21:19 ` Paul E. McKenney
2015-08-26 15:04 ` Kirill A. Shutemov
2015-08-26 15:39 ` Vlastimil Babka
2015-08-26 16:38 ` Paul E. McKenney
2015-08-26 18:18 ` Hugh Dickins
2015-08-26 21:29 ` Paul E. McKenney
2015-08-26 22:28 ` Hugh Dickins
2015-08-26 23:34 ` Paul E. McKenney
2015-08-27 15:09 ` Michal Hocko
2015-08-27 16:03 ` Michal Hocko
2015-08-27 17:28 ` Hugh Dickins
2015-08-27 18:06 ` Michal Hocko
2015-08-27 16:36 ` Paul E. McKenney
2015-08-27 18:14 ` Michal Hocko
2015-08-27 19:01 ` Paul E. McKenney
2015-08-23 23:59 ` Jesper Dangaard Brouer
2015-08-24 9:29 ` Kirill A. Shutemov
2015-08-24 10:17 ` Kirill A. Shutemov
2015-08-19 9:21 ` [PATCHv3 5/5] mm: use 'unsigned int' for page order Kirill A. Shutemov
2015-08-20 8:32 ` Michal Hocko
2015-08-20 12:31 ` [PATCHv3 0/5] Fix compound_head() race Kirill A. Shutemov
2015-08-20 23:38 ` Andrew Morton
2015-08-22 20:13 ` Hugh Dickins
2015-08-24 9:36 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439976106-137226-3-git-send-email-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).